openstack/charm-neutron-openvswitch
Code Issues Proposed changes

Change default mkdir permissions to 755 for deploy from source

Browse Source
This commit is contained in:
Corey Bryant 2015-04-17 12:13:07 +00:00
parent 76cd3d7e20
commit 37de2dc33c
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hooks/neutron_ovs_utils.py
View File

@ -239,7 +239,7 @@ def git_pre_install():
add_user_to_group('neutron', 'neutron')
for d in dirs:
mkdir(d, owner='neutron', group='neutron', perms=0700, force=False)
mkdir(d, owner='neutron', group='neutron', perms=0755, force=False)
for l in logs:
write_file(l, '', owner='neutron', group='neutron', perms=0600)

6
unit_tests/test_neutron_ovs_utils.py
View File

@ -247,11 +247,11 @@ class TestNeutronOVSUtils(CharmTestCase):
add_user_to_group.assert_called_with('neutron', 'neutron')
expected = [
call('/var/lib/neutron', owner='neutron',
group='neutron', perms=0700, force=False),
group='neutron', perms=0755, force=False),
call('/var/lib/neutron/lock', owner='neutron',
group='neutron', perms=0700, force=False),
group='neutron', perms=0755, force=False),
call('/var/log/neutron', owner='neutron',
group='neutron', perms=0700, force=False),
group='neutron', perms=0755, force=False),
]
self.assertEquals(mkdir.call_args_list, expected)
expected = [