From f6ca9abede6220599c208454a6017a9b6750f4e6 Mon Sep 17 00:00:00 2001 From: Corey Bryant Date: Fri, 11 Jul 2014 14:09:08 +0000 Subject: [PATCH] Add Amulet basic tests --- Makefile | 13 +- tests/00-setup | 10 + tests/10-basic-precise-essex | 9 + tests/11-basic-precise-folsom | 17 ++ tests/12-basic-precise-grizzly | 11 + tests/13-basic-precise-havana | 11 + tests/14-basic-precise-icehouse | 11 + tests/15-basic-trusty-icehouse | 9 + tests/README | 47 ++++ tests/basic_deployment.py | 406 ++++++++++++++++++++++++++++++++ 10 files changed, 541 insertions(+), 3 deletions(-) create mode 100755 tests/00-setup create mode 100755 tests/10-basic-precise-essex create mode 100755 tests/11-basic-precise-folsom create mode 100755 tests/12-basic-precise-grizzly create mode 100755 tests/13-basic-precise-havana create mode 100755 tests/14-basic-precise-icehouse create mode 100755 tests/15-basic-trusty-icehouse create mode 100644 tests/README create mode 100644 tests/basic_deployment.py diff --git a/Makefile b/Makefile index 3eedab17..1fb2bda6 100644 --- a/Makefile +++ b/Makefile @@ -2,13 +2,20 @@ PYTHON := /usr/bin/env python lint: - @flake8 --exclude hooks/charmhelpers hooks unit_tests + @flake8 --exclude hooks/charmhelpers hooks unit_tests tests @charm proof -test: - @echo Starting tests... +unit_test: + @echo Starting unit tests... @$(PYTHON) /usr/bin/nosetests --nologcapture --with-coverage unit_tests +test: + @echo Starting Amulet tests... + # coreycb note: The -v should only be temporary until Amulet sends + # raise_status() messages to stderr: + # https://bugs.launchpad.net/amulet/+bug/1320357 + @juju test -v -p AMULET_HTTP_PROXY + sync: @charm-helper-sync -c charm-helpers-hooks.yaml @charm-helper-sync -c charm-helpers-tests.yaml diff --git a/tests/00-setup b/tests/00-setup new file mode 100755 index 00000000..a877fa00 --- /dev/null +++ b/tests/00-setup @@ -0,0 +1,10 @@ +#!/bin/bash + +set -ex + +sudo add-apt-repository --yes ppa:juju/stable +sudo apt-get update --yes +sudo apt-get install --yes python-amulet +sudo apt-get install --yes python-glanceclient +sudo apt-get install --yes python-keystoneclient +sudo apt-get install --yes python-novaclient diff --git a/tests/10-basic-precise-essex b/tests/10-basic-precise-essex new file mode 100755 index 00000000..9a0413f3 --- /dev/null +++ b/tests/10-basic-precise-essex @@ -0,0 +1,9 @@ +#!/usr/bin/python + +"""Amulet tests on a basic nova compute deployment on precise-essex.""" + +from basic_deployment import NovaBasicDeployment + +if __name__ == '__main__': + deployment = NovaBasicDeployment(series='precise') + deployment.run_tests() diff --git a/tests/11-basic-precise-folsom b/tests/11-basic-precise-folsom new file mode 100755 index 00000000..59f0e25e --- /dev/null +++ b/tests/11-basic-precise-folsom @@ -0,0 +1,17 @@ +#!/usr/bin/python + +"""Amulet tests on a basic nova compute deployment on precise-folsom.""" + +import amulet +from basic_deployment import NovaBasicDeployment + +if __name__ == '__main__': + # NOTE(coreycb): Skipping failing test until resolved. 'nova-manage db sync' + # fails in shared-db-relation-changed (only fails on folsom) + message = "Skipping failing test until resolved" + amulet.raise_status(amulet.SKIP, msg=message) + + deployment = NovaBasicDeployment(series='precise', + openstack='cloud:precise-folsom', + source='cloud:precise-updates/folsom') + deployment.run_tests() diff --git a/tests/12-basic-precise-grizzly b/tests/12-basic-precise-grizzly new file mode 100755 index 00000000..82e4a0e1 --- /dev/null +++ b/tests/12-basic-precise-grizzly @@ -0,0 +1,11 @@ +#!/usr/bin/python + +"""Amulet tests on a basic nova compute deployment on precise-grizzly.""" + +from basic_deployment import NovaBasicDeployment + +if __name__ == '__main__': + deployment = NovaBasicDeployment(series='precise', + openstack='cloud:precise-grizzly', + source='cloud:precise-updates/grizzly') + deployment.run_tests() diff --git a/tests/13-basic-precise-havana b/tests/13-basic-precise-havana new file mode 100755 index 00000000..ba4043c8 --- /dev/null +++ b/tests/13-basic-precise-havana @@ -0,0 +1,11 @@ +#!/usr/bin/python + +"""Amulet tests on a basic nova compute deployment on precise-havana.""" + +from basic_deployment import NovaBasicDeployment + +if __name__ == '__main__': + deployment = NovaBasicDeployment(series='precise', + openstack='cloud:precise-havana', + source='cloud:precise-updates/havana') + deployment.run_tests() diff --git a/tests/14-basic-precise-icehouse b/tests/14-basic-precise-icehouse new file mode 100755 index 00000000..fe243fce --- /dev/null +++ b/tests/14-basic-precise-icehouse @@ -0,0 +1,11 @@ +#!/usr/bin/python + +"""Amulet tests on a basic nova compute deployment on precise-icehouse.""" + +from basic_deployment import NovaBasicDeployment + +if __name__ == '__main__': + deployment = NovaBasicDeployment(series='precise', + openstack='cloud:precise-icehouse', + source='cloud:precise-updates/icehouse') + deployment.run_tests() diff --git a/tests/15-basic-trusty-icehouse b/tests/15-basic-trusty-icehouse new file mode 100755 index 00000000..ab2ea633 --- /dev/null +++ b/tests/15-basic-trusty-icehouse @@ -0,0 +1,9 @@ +#!/usr/bin/python + +"""Amulet tests on a basic nova compute deployment on trusty-icehouse.""" + +from basic_deployment import NovaBasicDeployment + +if __name__ == '__main__': + deployment = NovaBasicDeployment(series='trusty') + deployment.run_tests() diff --git a/tests/README b/tests/README new file mode 100644 index 00000000..f252947a --- /dev/null +++ b/tests/README @@ -0,0 +1,47 @@ +This directory provides Amulet tests that focus on verification of nova-compute +deployments. + +If you use a web proxy server to access the web, you'll need to set the +AMULET_HTTP_PROXY environment variable to the http URL of the proxy server. + +The following examples demonstrate different ways that tests can be executed. +All examples are run from the charm's root directory. + + * To run all tests (starting with 00-setup): + + make test + + * To run a specific test module (or modules): + + juju test -v -p AMULET_HTTP_PROXY 15-basic-trusty-icehouse + + * To run a specific test module (or modules), and keep the environment + deployed after a failure: + + juju test --set-e -v -p AMULET_HTTP_PROXY 15-basic-trusty-icehouse + + * To re-run a test module against an already deployed environment (one + that was deployed by a previous call to 'juju test --set-e'): + + ./tests/15-basic-trusty-icehouse + +For debugging and test development purposes, all code should be idempotent. +In other words, the code should have the ability to be re-run without changing +the results beyond the initial run. This enables editing and re-running of a +test module against an already deployed environment, as described above. + +Manual debugging tips: + + * Set the following env vars before using the OpenStack CLI as admin: + export OS_AUTH_URL=http://`juju-deployer -f keystone 2>&1 | tail -n 1`:5000/v2.0 + export OS_TENANT_NAME=admin + export OS_USERNAME=admin + export OS_PASSWORD=openstack + export OS_REGION_NAME=RegionOne + + * Set the following env vars before using the OpenStack CLI as demoUser: + export OS_AUTH_URL=http://`juju-deployer -f keystone 2>&1 | tail -n 1`:5000/v2.0 + export OS_TENANT_NAME=demoTenant + export OS_USERNAME=demoUser + export OS_PASSWORD=password + export OS_REGION_NAME=RegionOne diff --git a/tests/basic_deployment.py b/tests/basic_deployment.py new file mode 100644 index 00000000..d92869fc --- /dev/null +++ b/tests/basic_deployment.py @@ -0,0 +1,406 @@ +#!/usr/bin/python + +import amulet + +from charmhelpers.contrib.openstack.amulet.deployment import ( + OpenStackAmuletDeployment +) + +from charmhelpers.contrib.openstack.amulet.utils import ( + OpenStackAmuletUtils, + DEBUG, # flake8: noqa + ERROR +) + +# Use DEBUG to turn on debug logging +u = OpenStackAmuletUtils(ERROR) + + +class NovaBasicDeployment(OpenStackAmuletDeployment): + """Amulet tests on a basic nova compute deployment.""" + + def __init__(self, series=None, openstack=None, source=None): + """Deploy the entire test environment.""" + super(NovaBasicDeployment, self).__init__(series, openstack, source) + self._add_services() + self._add_relations() + self._configure_services() + self._deploy() + self._initialize_tests() + + def _add_services(self): + """Add the service that we're testing, including the number of units, + where nova-compute is local, and the other charms are from + the charm store.""" + this_service = ('nova-compute', 1) + other_services = [('mysql', 1), ('rabbitmq-server', 1), + ('nova-cloud-controller', 1), ('keystone', 1), + ('glance', 1)] + super(NovaBasicDeployment, self)._add_services(this_service, + other_services) + + def _add_relations(self): + """Add all of the relations for the services.""" + relations = { + 'nova-compute:image-service': 'glance:image-service', + 'nova-compute:shared-db': 'mysql:shared-db', + 'nova-compute:amqp': 'rabbitmq-server:amqp', + 'nova-cloud-controller:shared-db': 'mysql:shared-db', + 'nova-cloud-controller:identity-service': 'keystone:identity-service', + 'nova-cloud-controller:amqp': 'rabbitmq-server:amqp', + 'nova-cloud-controller:cloud-compute': 'nova-compute:cloud-compute', + 'nova-cloud-controller:image-service': 'glance:image-service', + 'keystone:shared-db': 'mysql:shared-db', + 'glance:identity-service': 'keystone:identity-service', + 'glance:shared-db': 'mysql:shared-db', + 'glance:amqp': 'rabbitmq-server:amqp' + } + super(NovaBasicDeployment, self)._add_relations(relations) + + def _configure_services(self): + """Configure all of the services.""" + nova_config = {'config-flags': 'auto_assign_floating_ip=False', + 'enable-live-migration': 'False'} + keystone_config = {'admin-password': 'openstack', + 'admin-token': 'ubuntutesting'} + configs = {'nova-compute': nova_config, 'keystone': keystone_config} + super(NovaBasicDeployment, self)._configure_services(configs) + + def _initialize_tests(self): + """Perform final initialization before tests get run.""" + # Access the sentries for inspecting service units + self.mysql_sentry = self.d.sentry.unit['mysql/0'] + self.keystone_sentry = self.d.sentry.unit['keystone/0'] + self.rabbitmq_sentry = self.d.sentry.unit['rabbitmq-server/0'] + self.nova_compute_sentry = self.d.sentry.unit['nova-compute/0'] + self.nova_cc_sentry = self.d.sentry.unit['nova-cloud-controller/0'] + self.glance_sentry = self.d.sentry.unit['glance/0'] + + # Authenticate admin with keystone + self.keystone = u.authenticate_keystone_admin(self.keystone_sentry, + user='admin', + password='openstack', + tenant='admin') + + # Authenticate admin with glance endpoint + self.glance = u.authenticate_glance_admin(self.keystone) + + # Create a demo tenant/role/user + self.demo_tenant = 'demoTenant' + self.demo_role = 'demoRole' + self.demo_user = 'demoUser' + if not u.tenant_exists(self.keystone, self.demo_tenant): + tenant = self.keystone.tenants.create(tenant_name=self.demo_tenant, + description='demo tenant', + enabled=True) + self.keystone.roles.create(name=self.demo_role) + self.keystone.users.create(name=self.demo_user, + password='password', + tenant_id=tenant.id, + email='demo@demo.com') + + # Authenticate demo user with keystone + self.keystone_demo = \ + u.authenticate_keystone_user(self.keystone, user=self.demo_user, + password='password', + tenant=self.demo_tenant) + + # Authenticate demo user with nova-api + self.nova_demo = u.authenticate_nova_user(self.keystone, + user=self.demo_user, + password='password', + tenant=self.demo_tenant) + + def test_services(self): + """Verify the expected services are running on the corresponding + service units.""" + commands = { + self.mysql_sentry: ['status mysql'], + self.rabbitmq_sentry: ['sudo service rabbitmq-server status'], + self.nova_compute_sentry: ['status nova-compute', + 'status nova-network', + 'status nova-api'], + self.nova_cc_sentry: ['status nova-api-ec2', + 'status nova-api-os-compute', + 'status nova-objectstore', + 'status nova-cert', + 'status nova-scheduler'], + self.keystone_sentry: ['status keystone'], + self.glance_sentry: ['status glance-registry', 'status glance-api'] + } + if self._get_openstack_release() >= self.precise_grizzly: + commands[self.nova_cc_sentry] = ['status nova-conductor'] + + ret = u.validate_services(commands) + if ret: + amulet.raise_status(amulet.FAIL, msg=ret) + + def test_service_catalog(self): + """Verify that the service catalog endpoint data is valid.""" + endpoint_vol = {'adminURL': u.valid_url, + 'region': 'RegionOne', + 'publicURL': u.valid_url, + 'internalURL': u.valid_url} + endpoint_id = {'adminURL': u.valid_url, + 'region': 'RegionOne', + 'publicURL': u.valid_url, + 'internalURL': u.valid_url} + if self._get_openstack_release() >= self.precise_folsom: + endpoint_vol['id'] = u.not_null + endpoint_id['id'] = u.not_null + expected = {'s3': [endpoint_vol], 'compute': [endpoint_vol], + 'ec2': [endpoint_vol], 'identity': [endpoint_id]} + actual = self.keystone_demo.service_catalog.get_endpoints() + + ret = u.validate_svc_catalog_endpoint_data(expected, actual) + if ret: + amulet.raise_status(amulet.FAIL, msg=ret) + + def test_openstack_compute_api_endpoint(self): + """Verify the openstack compute api (osapi) endpoint data.""" + endpoints = self.keystone.endpoints.list() + admin_port = internal_port = public_port = '8774' + expected = {'id': u.not_null, + 'region': 'RegionOne', + 'adminurl': u.valid_url, + 'internalurl': u.valid_url, + 'publicurl': u.valid_url, + 'service_id': u.not_null} + + ret = u.validate_endpoint_data(endpoints, admin_port, internal_port, + public_port, expected) + if ret: + message = 'osapi endpoint: {}'.format(ret) + amulet.raise_status(amulet.FAIL, msg=message) + + def test_ec2_api_endpoint(self): + """Verify the EC2 api endpoint data.""" + endpoints = self.keystone.endpoints.list() + admin_port = internal_port = public_port = '8773' + expected = {'id': u.not_null, + 'region': 'RegionOne', + 'adminurl': u.valid_url, + 'internalurl': u.valid_url, + 'publicurl': u.valid_url, + 'service_id': u.not_null} + + ret = u.validate_endpoint_data(endpoints, admin_port, internal_port, + public_port, expected) + if ret: + message = 'EC2 endpoint: {}'.format(ret) + amulet.raise_status(amulet.FAIL, msg=message) + + def test_s3_api_endpoint(self): + """Verify the S3 api endpoint data.""" + endpoints = self.keystone.endpoints.list() + admin_port = internal_port = public_port = '3333' + expected = {'id': u.not_null, + 'region': 'RegionOne', + 'adminurl': u.valid_url, + 'internalurl': u.valid_url, + 'publicurl': u.valid_url, + 'service_id': u.not_null} + + ret = u.validate_endpoint_data(endpoints, admin_port, internal_port, + public_port, expected) + if ret: + message = 'S3 endpoint: {}'.format(ret) + amulet.raise_status(amulet.FAIL, msg=message) + + def test_nova_shared_db_relation(self): + """Verify the nova-compute to mysql shared-db relation data""" + unit = self.nova_compute_sentry + relation = ['shared-db', 'mysql:shared-db'] + expected = { + 'private-address': u.valid_ip, + 'nova_database': 'nova', + 'nova_username': 'nova', + 'nova_hostname': u.valid_ip + } + + ret = u.validate_relation_data(unit, relation, expected) + if ret: + message = u.relation_error('nova-compute shared-db', ret) + amulet.raise_status(amulet.FAIL, msg=message) + + def test_mysql_shared_db_relation(self): + """Verify the mysql to nova-compute shared-db relation data""" + unit = self.mysql_sentry + relation = ['shared-db', 'nova-compute:shared-db'] + expected = { + 'private-address': u.valid_ip, + 'nova_password': u.not_null, + 'db_host': u.valid_ip + } + + ret = u.validate_relation_data(unit, relation, expected) + if ret: + message = u.relation_error('mysql shared-db', ret) + amulet.raise_status(amulet.FAIL, msg=message) + + def test_nova_amqp_relation(self): + """Verify the nova-compute to rabbitmq-server amqp relation data""" + unit = self.nova_compute_sentry + relation = ['amqp', 'rabbitmq-server:amqp'] + expected = { + 'username': 'nova', + 'private-address': u.valid_ip, + 'vhost': 'openstack' + } + + ret = u.validate_relation_data(unit, relation, expected) + if ret: + message = u.relation_error('nova-compute amqp', ret) + amulet.raise_status(amulet.FAIL, msg=message) + + def test_rabbitmq_amqp_relation(self): + """Verify the rabbitmq-server to nova-compute amqp relation data""" + unit = self.rabbitmq_sentry + relation = ['amqp', 'nova-compute:amqp'] + expected = { + 'private-address': u.valid_ip, + 'password': u.not_null, + 'hostname': u.valid_ip + } + + ret = u.validate_relation_data(unit, relation, expected) + if ret: + message = u.relation_error('rabbitmq amqp', ret) + amulet.raise_status(amulet.FAIL, msg=message) + + def test_nova_cloud_compute_relation(self): + """Verify the nova-compute to nova-cc cloud-compute relation data""" + unit = self.nova_compute_sentry + relation = ['cloud-compute', 'nova-cloud-controller:cloud-compute'] + expected = { + 'private-address': u.valid_ip, + } + + ret = u.validate_relation_data(unit, relation, expected) + if ret: + message = u.relation_error('nova-compute cloud-compute', ret) + amulet.raise_status(amulet.FAIL, msg=message) + + def test_nova_cc_cloud_compute_relation(self): + """Verify the nova-cc to nova-compute cloud-compute relation data""" + unit = self.nova_cc_sentry + relation = ['cloud-compute', 'nova-compute:cloud-compute'] + expected = { + 'volume_service': 'cinder', + 'network_manager': 'flatdhcpmanager', + 'ec2_host': u.valid_ip, + 'private-address': u.valid_ip, + 'restart_trigger': u.not_null + } + if self._get_openstack_release() == self.precise_essex: + expected['volume_service'] = 'nova-volume' + + ret = u.validate_relation_data(unit, relation, expected) + if ret: + message = u.relation_error('nova-cc cloud-compute', ret) + amulet.raise_status(amulet.FAIL, msg=message) + + def test_restart_on_config_change(self): + """Verify that the specified services are restarted when the config + is changed.""" + # NOTE(coreycb): Skipping failing test on essex until resolved. + # config-flags don't take effect on essex. + if self._get_openstack_release() == self.precise_essex: + u.log.error("Skipping failing test until resolved") + return + + services = ['nova-compute', 'nova-api', 'nova-network'] + self.d.configure('nova-compute', {'config-flags': 'verbose=False'}) + + time = 20 + for s in services: + if not u.service_restarted(self.nova_compute_sentry, s, + '/etc/nova/nova.conf', sleep_time=time): + msg = "service {} didn't restart after config change".format(s) + amulet.raise_status(amulet.FAIL, msg=msg) + time = 0 + + self.d.configure('nova-compute', {'config-flags': 'verbose=True'}) + + def test_nova_config(self): + """Verify the data in the nova config file.""" + # NOTE(coreycb): Currently no way to test on essex because config file + # has no section headers. + if self._get_openstack_release() == self.precise_essex: + return + + unit = self.nova_compute_sentry + conf = '/etc/nova/nova.conf' + rabbitmq_relation = self.rabbitmq_sentry.relation('amqp', + 'nova-compute:amqp') + glance_relation = self.glance_sentry.relation('image-service', + 'nova-compute:image-service') + mysql_relation = self.mysql_sentry.relation('shared-db', + 'nova-compute:shared-db') + db_uri = "mysql://{}:{}@{}/{}".format('nova', + mysql_relation['nova_password'], + mysql_relation['db_host'], + 'nova') + + expected = {'dhcpbridge_flagfile': '/etc/nova/nova.conf', + 'dhcpbridge': '/usr/bin/nova-dhcpbridge', + 'logdir': '/var/log/nova', + 'state_path': '/var/lib/nova', + 'lock_path': '/var/lock/nova', + 'force_dhcp_release': 'True', + 'libvirt_use_virtio_for_bridges': 'True', + 'verbose': 'True', + 'use_syslog': 'False', + 'ec2_private_dns_show_ip': 'True', + 'api_paste_config': '/etc/nova/api-paste.ini', + 'enabled_apis': 'ec2,osapi_compute,metadata', + 'auth_strategy': 'keystone', + 'compute_driver': 'libvirt.LibvirtDriver', + 'sql_connection': db_uri, + 'rabbit_userid': 'nova', + 'rabbit_virtual_host': 'openstack', + 'rabbit_password': rabbitmq_relation['password'], + 'rabbit_host': rabbitmq_relation['hostname'], + 'glance_api_servers': glance_relation['glance-api-server'], + 'flat_interface': 'eth1', + 'network_manager': 'nova.network.manager.FlatDHCPManager', + 'volume_api_class': 'nova.volume.cinder.API', + 'verbose': 'True'} + + ret = u.validate_config_data(unit, conf, 'DEFAULT', expected) + if ret: + message = "nova config error: {}".format(ret) + amulet.raise_status(amulet.FAIL, msg=message) + + def test_image_instance_create(self): + """Create an image/instance, verify they exist, and delete them.""" + # NOTE(coreycb): Skipping failing test on essex until resolved. essex + # nova API calls are getting "Malformed request url (HTTP + # 400)". + if self._get_openstack_release() == self.precise_essex: + u.log.error("Skipping failing test until resolved") + return + + image = u.create_cirros_image(self.glance, "cirros-image") + if not image: + amulet.raise_status(amulet.FAIL, msg="Image create failed") + + instance = u.create_instance(self.nova_demo, "cirros-image", "cirros", + "m1.tiny") + if not instance: + amulet.raise_status(amulet.FAIL, msg="Instance create failed") + + found = False + for instance in self.nova_demo.servers.list(): + if instance.name == 'cirros': + found = True + if instance.status != 'ACTIVE': + msg = "cirros instance is not active" + amulet.raise_status(amulet.FAIL, msg=message) + + if not found: + message = "nova cirros instance does not exist" + amulet.raise_status(amulet.FAIL, msg=message) + + u.delete_image(self.glance, image) + u.delete_instance(self.nova_demo, instance)