openstack/deb-spice-html5
Code Issues Proposed changes

Use empty image instead of null to avoid warnings

Browse Source
This commit is contained in:
Jeremy White 2016-09-28 10:11:55 -05:00
parent dd3fb12678
commit 42134d3e56
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
display.js
View File

@ -933,7 +933,7 @@ function handle_draw_jpeg_onload()
// Give the Garbage collector a clue to recycle this; avoids // Give the Garbage collector a clue to recycle this; avoids
// fairly massive memory leaks during video playback // fairly massive memory leaks during video playback
this.src = null; this.src = EMPTY_GIF_IMAGE;
if (this.o.descriptor && if (this.o.descriptor &&
(this.o.descriptor.flags & SPICE_IMAGE_FLAGS_CACHE_ME)) (this.o.descriptor.flags & SPICE_IMAGE_FLAGS_CACHE_ME))

5
utils.js
View File

@ -27,6 +27,11 @@ var STREAM_DEBUG = 0;
var DUMP_DRAWS = false; var DUMP_DRAWS = false;
var DUMP_CANVASES = false; var DUMP_CANVASES = false;
/*----------------------------------------------------------------------------
** We use an Image temporarily, and the image/src does not get garbage
** collected as quickly as we might like. This blank image helps with that.
**--------------------------------------------------------------------------*/
var EMPTY_GIF_IMAGE = "data:image/gif;base64,R0lGODlhAQABAAD/ACwAAAAAAQABAAACADs=";
/*---------------------------------------------------------------------------- /*----------------------------------------------------------------------------
** combine_array_buffers ** combine_array_buffers