openstack/devstack
Code Issues Proposed changes

Disable memory_tracker and file_tracker in unstask.sh properly

Browse Source 
stop_dstat() calls stop_process() for dstat, memory_tracker and
file_tracker respectively. Inside stop_process(), a check for the
existence of the service is performed by is_service_enabled().

So even if we apply this seemingly dangerous commit,
is_service_enabled() is respected, so it's safe.

Closes-Bug: #1998990
Change-Id: Ica58cdb1d60c4c796f582d82ed2cde0be94b1a7e
Signed-off-by: Nobuhiro MIKI <nmiki@yahoo-corp.jp>
This commit is contained in:
Nobuhiro MIKI 2023-02-22 10:38:49 +09:00
parent e5c8e2951f
commit 0572d73f85
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
unstack.sh
View File

@ -168,9 +168,7 @@ if is_service_enabled etcd3; then
cleanup_etcd3 cleanup_etcd3
fi fi
if is_service_enabled dstat; then stop_dstat
stop_dstat
fi
# NOTE: Cinder automatically installs the lvm2 package, independently of the # NOTE: Cinder automatically installs the lvm2 package, independently of the
# enabled backends. So if Cinder is enabled, and installed successfully we are # enabled backends. So if Cinder is enabled, and installed successfully we are