openstack/devstack
Code Issues Proposed changes

Use urandom rather than openssl for password gen

Browse Source 
I tried using devstack on a cloud image that didn't have openssl, so
it generated blank passwords and gave an error about openssl missing.
Using urandom should not require more than minimal shell tools.

Change-Id: Ib3091183eb1d85fc8cf7c76e47da24a04ae4791f
This commit is contained in:
Ian Wienand 2014-05-14 14:10:47 +10:00
parent 8cedabcea8
commit 26a28b4af5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
stack.sh
View File

@ -410,7 +410,7 @@ function read_password {
echo "Invalid chars in password. Try again:" echo "Invalid chars in password. Try again:"
done done
if [ ! $pw ]; then if [ ! $pw ]; then
pw=`openssl rand -hex 10` pw=$(cat /dev/urandom | tr -cd 'a-f0-9' | head -c 20)
fi fi
eval "$var=$pw" eval "$var=$pw"
echo "$var=$pw" >> $localrc echo "$var=$pw" >> $localrc