openstack/devstack
Code Issues Proposed changes

Clean up compile_ovn function's parameters

Browse Source 
That function was accepting 3 positional arguments and first
of them was boolean value "build_modules" which isn't used anywhere in
that function.
So this patch cleans it a bit by removing that not used parameter.

Change-Id: I5c57b9116338a63b7bfb170c02e33bb4eae725da
This commit is contained in:
Slawek Kaplonski 2021-12-22 16:00:29 +01:00
parent 6c849e3713
commit 5888947539
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/neutron_plugins/ovn_agent
View File

@ -294,16 +294,13 @@ function _disable_libvirt_apparmor {
# compile_ovn() - Compile OVN from source and load needed modules
# Accepts three parameters:
# - first optional is False by default and means that
# modules are built and installed.
# - second optional parameter defines prefix for
# - first optional parameter defines prefix for
# ovn compilation
# - third optional parameter defines localstatedir for
# - second optional parameter defines localstatedir for
# ovn single machine runtime
function compile_ovn {
local build_modules=${1:-False}
local prefix=$2
local localstatedir=$3
local prefix=$1
local localstatedir=$2
if [ -n "$prefix" ]; then
prefix="--prefix=$prefix"
@ -381,7 +378,7 @@ function install_ovn {
compile_ovs $OVN_BUILD_MODULES
if use_new_ovn_repository; then
compile_ovn $OVN_BUILD_MODULES
compile_ovn
fi
sudo mkdir -p $OVS_PREFIX/var/log/openvswitch