openstack/devstack
Code Issues Proposed changes

USe trueorfalse for INSTALL_TESTONLY_PACKAGES

Browse Source 
INSTALL_TESTONLY_PACKAGES is assumed to be set to `True` or `False`.
However, in devstack-gate this variable is set to 0 or 1. The patch uses
the already existing `trueorfalse` function to evaluate
INSTALL_TESTONLY_PACKAGES and normalize its value.

Change-Id: I0e4a31e422bad2a31d919d9f871e24833a0faa99
This commit is contained in:
Flavio Percoco 2014-10-31 18:48:00 +01:00
parent 219a58e57b
commit 5a91c35483
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
functions-common
View File

@ -993,6 +993,8 @@ function get_packages {
local file_to_parse
local service
INSTALL_TESTONLY_PACKAGES=$(trueorfalse False $INSTALL_TESTONLY_PACKAGES)
if [[ -z "$package_dir" ]]; then
echo "No package directory supplied"
return 1
@ -1599,6 +1601,7 @@ function pip_install {
$cmd_pip install \
$pip_mirror_opt $@
INSTALL_TESTONLY_PACKAGES=$(trueorfalse False $INSTALL_TESTONLY_PACKAGES)
if [[ "$INSTALL_TESTONLY_PACKAGES" == "True" ]]; then
local test_req="$@/test-requirements.txt"
if [[ -e "$test_req" ]]; then