openstack/devstack
Code Issues Proposed changes

generate-devstack-plugins-list: Retry on opendev.org 500

Browse Source 
A 500 error from gitea can occasionally show up as a project dropping
their devstack plugin (I543faced83a685d48706d004ae49800abfb89dc5).

To avoid noise in the proposal jobs, implement a small retry loop for
500 errors.

Change-Id: Ide23e4de819a2c751d887eeaa7f0b9d0437f8e2c
This commit is contained in:
Ian Wienand 2019-09-25 08:30:07 +10:00
parent 1a46c898db
commit 893817d30a
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tools/generate-devstack-plugins-list.py
View File

@ -28,6 +28,9 @@ import logging
import json import json
import requests import requests
from requests.adapters import HTTPAdapter
from requests.packages.urllib3.util.retry import Retry
logging.basicConfig(level=logging.DEBUG) logging.basicConfig(level=logging.DEBUG)
url = 'https://review.opendev.org/projects/' url = 'https://review.opendev.org/projects/'
@ -63,6 +66,12 @@ projects = sorted(filter(is_in_wanted_namespace, json.loads(r.text[4:])))
logging.debug("Found %d projects" % len(projects)) logging.debug("Found %d projects" % len(projects))
s = requests.Session() s = requests.Session()
# sometimes gitea gives us a 500 error; retry sanely
# https://stackoverflow.com/a/35636367
retries = Retry(total=3, backoff_factor=1,
status_forcelist=[ 500 ])
s.mount('https://', HTTPAdapter(max_retries=retries))
found_plugins = filter(functools.partial(has_devstack_plugin, s), projects) found_plugins = filter(functools.partial(has_devstack_plugin, s), projects)
for project in found_plugins: for project in found_plugins: