openstack/devstack
Code Issues Proposed changes

move sysstat earlier (but not too early)

Browse Source 
sysstat was starting too late to understand the state of the system
when services didn't start. Move it to earlier.

Change-Id: Iaf8e72c441dbdf943f7f25ea3f0fc568138a178f
This commit is contained in:
Sean Dague 2013-02-26 10:35:59 -05:00
parent 555ecd07b0
commit 921f2dab62
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
stack.sh
View File

@ -410,7 +410,6 @@ FLAT_INTERFACE=${FLAT_INTERFACE-$GUEST_INTERFACE_DEFAULT}
## FIXME(ja): should/can we check that FLAT_INTERFACE is sane? ## FIXME(ja): should/can we check that FLAT_INTERFACE is sane?
# Database Configuration # Database Configuration
# ---------------------- # ----------------------
@ -845,6 +844,18 @@ screen -r $SCREEN_NAME -X hardstatus alwayslastline "$SCREEN_HARDSTATUS"
# Initialize the directory for service status check # Initialize the directory for service status check
init_service_check init_service_check
# Kick off Sysstat
# ------------------------
# run sysstat if it is enabled, this has to be early as daemon
# startup is one of the things to track.
if is_service_enabled sysstat;then
if [[ -n ${SCREEN_LOGDIR} ]]; then
screen_it sysstat "sar -o $SCREEN_LOGDIR/$SYSSTAT_FILE $SYSSTAT_INTERVAL"
else
screen_it sysstat "sar $SYSSTAT_INTERVAL"
fi
fi
# Keystone # Keystone
# -------- # --------
@ -1275,14 +1286,6 @@ if is_service_enabled nova && is_baremetal; then
screen_it baremetal "nova-baremetal-deploy-helper" screen_it baremetal "nova-baremetal-deploy-helper"
fi fi
# run sysstat if it is enabled
if is_service_enabled sysstat;then
if [[ -n ${SCREEN_LOGDIR} ]]; then
screen_it sysstat "sar -o $SCREEN_LOGDIR/$SYSSTAT_FILE $SYSSTAT_INTERVAL"
else
screen_it sysstat "sar $SYSSTAT_INTERVAL"
fi
fi
# Save some values we generated for later use # Save some values we generated for later use
CURRENT_RUN_TIME=$(date "+$TIMESTAMP_FORMAT") CURRENT_RUN_TIME=$(date "+$TIMESTAMP_FORMAT")