openstack/devstack
Code Issues Proposed changes

Handle uwsgi on systemd properly

Browse Source 
uwsgi is a different service type under systemd and shouldn't be run as
a standard oneshot type. The uwsgi docs outline a good pattern for
writing systemd unit files:

http://uwsgi-docs.readthedocs.io/en/latest/Systemd.html

This commit takes those suggestions and creates a separate path for
writing uwsgi unit files.

Change-Id: I9b541b86781afdded311dba058cedd783e1a0dfa
This commit is contained in:
Matthew Treinish 2017-03-29 16:47:57 -04:00
parent def07b21f8
commit 9c5ffd8d13
No known key found for this signature in database
GPG Key ID: FD12A0F214C9E177
2 changed files with 36 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
functions-common
View File

@ -1467,6 +1467,32 @@ function write_user_unit_file {
$SYSTEMCTL daemon-reload $SYSTEMCTL daemon-reload
} }
function write_uwsgi_user_unit_file {
local service=$1
local command="$2"
local group=$3
local user=$4
local unitfile="$SYSTEMD_DIR/$service"
mkdir -p $SYSTEMD_DIR
iniset -sudo $unitfile "Unit" "Description" "Devstack $service"
iniset -sudo $unitfile "Service" "User" "$user"
iniset -sudo $unitfile "Service" "ExecStart" "$command"
iniset -sudo $unitfile "Service" "Type" "notify"
iniset -sudo $unitfile "Service" "KillSignal" "SIGQUIT"
iniset -sudo $unitfile "Service" "Restart" "Always"
iniset -sudo $unitfile "Service" "NotifyAccess" "all"
iniset -sudo $unitfile "Service" "RestartForceExitStatus" "100"
if [[ -n "$group" ]]; then
iniset -sudo $unitfile "Service" "Group" "$group"
fi
iniset -sudo $unitfile "Install" "WantedBy" "multi-user.target"
# changes to existing units sometimes need a refresh
$SYSTEMCTL daemon-reload
}
function _run_under_systemd { function _run_under_systemd {
local service=$1 local service=$1
local command="$2" local command="$2"
@ -1474,7 +1500,11 @@ function _run_under_systemd {
local systemd_service="devstack@$service.service" local systemd_service="devstack@$service.service"
local group=$3 local group=$3
local user=${4:-$STACK_USER} local user=${4:-$STACK_USER}
if [[ "$command" =~ "uwsgi" ]] ; then
write_uwsgi_user_unit_file $systemd_service "$cmd" "$group" "$user"
else
write_user_unit_file $systemd_service "$cmd" "$group" "$user" write_user_unit_file $systemd_service "$cmd" "$group" "$user"
fi
$SYSTEMCTL enable $systemd_service $SYSTEMCTL enable $systemd_service
$SYSTEMCTL start $systemd_service $SYSTEMCTL start $systemd_service

7
lib/keystone
View File

@ -604,8 +604,8 @@ function start_keystone {
# TODO(sdague): we should really get down to a single keystone here # TODO(sdague): we should really get down to a single keystone here
enable_service key-p enable_service key-p
enable_service key-a enable_service key-a
run_process key-p "$KEYSTONE_BIN_DIR/uwsgi $KEYSTONE_PUBLIC_UWSGI_FILE" "" run_process key-p "$KEYSTONE_BIN_DIR/uwsgi --ini $KEYSTONE_PUBLIC_UWSGI_FILE" ""
run_process key-a "$KEYSTONE_BIN_DIR/uwsgi $KEYSTONE_ADMIN_UWSGI_FILE" "" run_process key-a "$KEYSTONE_BIN_DIR/uwsgi --ini $KEYSTONE_ADMIN_UWSGI_FILE" ""
fi fi
echo "Waiting for keystone to start..." echo "Waiting for keystone to start..."
@ -638,6 +638,9 @@ function stop_keystone {
if [ "$KEYSTONE_DEPLOY" == "mod_wsgi" ]; then if [ "$KEYSTONE_DEPLOY" == "mod_wsgi" ]; then
disable_apache_site keystone disable_apache_site keystone
restart_apache_server restart_apache_server
else
stop_process key-p
stop_process key-a
fi fi
# Kill the Keystone screen window # Kill the Keystone screen window
stop_process key stop_process key