From 403fbb1d33a3bbb0901d1a696ef68a3fe099dd70 Mon Sep 17 00:00:00 2001 From: Matthew Treinish Date: Mon, 24 Aug 2015 21:17:37 -0400 Subject: [PATCH] Fix trueorfalse call in tempest use accounts check The lib/tempest variable definition for TEMPEST_USE_TEST_ACCOUNTS was incorrectly calling the trueorfalse function by passing the variable's value to the function instead of the variable's name. This was causing trueorfalse the default value of false to always be returned even when specifying the option as true in the localrc. (well assuming True or it's variants wasn't an actual defined variable with a value that would return true) This commit fixes this issue by properly using the trueorfalse function. Change-Id: I8cefb58f49dcd2cb2def8a5071d0892af520e7f7 --- lib/tempest | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/tempest b/lib/tempest index e7f825f417..fe63015c5d 100644 --- a/lib/tempest +++ b/lib/tempest @@ -89,7 +89,7 @@ TEMPEST_HAS_ADMIN=$(trueorfalse True TEMPEST_HAS_ADMIN) # Credential provider configuration option variables TEMPEST_ALLOW_TENANT_ISOLATION=${TEMPEST_ALLOW_TENANT_ISOLATION:-$TEMPEST_HAS_ADMIN} -TEMPEST_USE_TEST_ACCOUNTS=$(trueorfalse False $TEMPEST_USE_TEST_ACCOUNTS) +TEMPEST_USE_TEST_ACCOUNTS=$(trueorfalse False TEMPEST_USE_TEST_ACCOUNTS) # The number of workers tempest is expected to be run with. This is used for # generating a accounts.yaml for running with test-accounts. This is also the