openstack/devstack
Code Issues Proposed changes

Add workaround for openstacksdk in check_libs_from_git

Browse Source 
python-openstacksdk does not match its pip name which is openstacksdk.
So setting python-openstacksdk in LIBS_FROM_GIT leads to devstack
thinking there is a problem.

Put in a workaround for now. It would be better to either:

  a) rename python-openstacksdk repo to openstacksdk
  b) rename the pip name for openstacksdk back to python-openstacksdk
  c) add general support in the various GIT hashes for a pip name

Change-Id: I57cf95763d54ad2060a4ce2af91c3ba18ca04db0
This commit is contained in:
Monty Taylor 2017-12-03 10:21:26 -06:00
parent 9ef3e84485
commit e46f22db7f
No known key found for this signature in database
GPG Key ID: 7BAE94BC7141A594
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
inc/python
View File

@ -407,6 +407,12 @@ function use_library_from_git {
function lib_installed_from_git { function lib_installed_from_git {
local name=$1 local name=$1
local safe_name local safe_name
# TODO(mordred) This is a special case for python-openstacksdk, where the
# repo name and the pip name do not match. We should either add systemic
# support for providing aliases, or we should rename the git repo.
if [[ $name == 'python-openstacksdk' ]] ; then
name=openstacksdk
fi
safe_name=$(python -c "from pkg_resources import safe_name; \ safe_name=$(python -c "from pkg_resources import safe_name; \
print(safe_name('${name}'))") print(safe_name('${name}'))")
# Note "pip freeze" doesn't always work here, because it tries to # Note "pip freeze" doesn't always work here, because it tries to