openstack/devstack
Code Issues Proposed changes

Use venv for VIRTUALENV_CMD

Browse Source 
Using venv, which is part of python3, we avoid an extra dependency on
the virtualenv package.  For Debuntu, which splits this out into a
separate package, add this to debs/general.

This is part of the infra efforts to ship "plain" nodes without any
dependencies installed.  While devstack can re-install virtualenv, we
don't need any features it provides and it means one less dependency.

Change-Id: I3c323640f288e57581a4eb8adba2a08d0b0cbd8f
This commit is contained in:
Ian Wienand 2020-03-12 15:18:11 +11:00
parent 01826e1c5b
commit e6852eadb1
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
files/debs/general
View File

@ -28,6 +28,7 @@ openssl
pkg-config pkg-config
psmisc psmisc
python3-dev python3-dev
python3-venv
tar tar
tcpdump tcpdump
unzip unzip

3
stackrc
View File

@ -150,7 +150,8 @@ export PYTHON2_VERSION=${PYTHON2_VERSION:-${_DEFAULT_PYTHON2_VERSION:-2.7}}
# Create a virtualenv with this # Create a virtualenv with this
if [[ ${USE_PYTHON3} == True ]]; then if [[ ${USE_PYTHON3} == True ]]; then
export VIRTUALENV_CMD="virtualenv -p python3" # Use the built-in venv to avoid more dependencies
export VIRTUALENV_CMD="python3 -m venv"
else else
export VIRTUALENV_CMD="virtualenv " export VIRTUALENV_CMD="virtualenv "
fi fi