openstack/devstack
Code Issues Proposed changes

Remove sgabios.bin workaround

Browse Source 
The bug has been fixed since a while, also in recent distributions,
for example Ubuntu 20.04, the sgabios.bin ROM is provided directly
by qemu-system-data as an actual file under /usr/share/qemu and
it conflicts with the one provided by sgabios, so removing the
workaround is actually needed to prevent failures.

Change-Id: Ib5f23dbd8839a0927418692054f4ed4abd76babc
This commit is contained in:
Riccardo Pittau 2020-05-14 11:35:03 +02:00
parent 54edc7aeef
commit e726ecb537
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/nova_plugins/hypervisor-ironic
View File

@ -68,13 +68,6 @@ function install_nova_hypervisor {
return return
fi fi
install_libvirt install_libvirt
if [[ "$IRONIC_VM_LOG_CONSOLE" == "True" ]] && is_ubuntu; then
# Ubuntu packaging+apparmor issue prevents libvirt from loading
# the ROM from /usr/share/misc. Workaround by installing it directly
# to a directory that it can read from. (LP: #1393548)
sudo rm -rf /usr/share/qemu/sgabios.bin
sudo cp /usr/share/misc/sgabios.bin /usr/share/qemu/sgabios.bin
fi
} }
# start_nova_hypervisor - Start any required external services # start_nova_hypervisor - Start any required external services