openstack/election
Code Issues Proposed changes

Reduce the changes checked by check-all-candidacies

Browse Source 
Currently check-all-candidacies will check all open changes but we can
trivially get gerrit to only return changes that touch candidate files.

Change-Id: I4c39bcb859fa87aab9c27a2bcacd8a3fd30a1914
This commit is contained in:
Tony Breeds 2016-09-12 09:30:17 +10:00
parent b285d3dd9c
commit 5295ca7a72
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
openstack_election/cmds/check_all_candidacies.py
View File

@ -21,8 +21,9 @@ from openstack_election import utils
def get_reviews():
return utils.get_reviews('is:open project:%s' %
(utils.ELECTION_REPO))
return utils.get_reviews('is:open project:%s file:^%s/%s/.*' %
(utils.ELECTION_REPO, utils.CANDIDATE_PATH,
utils.SERIES_NAME))
def main():

3
openstack_election/utils.py
View File

@ -34,6 +34,7 @@ PERIOD_END = datetime.datetime(2016, 9, 4, 23, 59, 59, tzinfo=pytz.utc)
PROJECTS_TAG = 'sept-2016-elections'
# Library constants
CANDIDATE_PATH = 'candidates'
GERRIT_BASE = 'https://review.openstack.org'
ELECTION_REPO = 'openstack/election'
BASE_URL = 'https://git.openstack.org/cgit'
@ -64,7 +65,7 @@ def get_reviews(query):
def candidate_files(review):
return list(filter(lambda x: x.startswith("candidates/"),
return list(filter(lambda x: x.startswith(CANDIDATE_PATH),
list(review['revisions'].values())[0]['files'].keys()))