openstack/eslint-config-openstack
Code Issues Proposed changes

Clarified wording in governance

Browse Source 
This patch clarifies the wording on a few governance statements.
First, the intent of the rule approval policy is to encourage more
pairs of eyeballs - thus the wording was changed from +5 to 'five
positive votes'. Secondly - library upgrades should _never_ change
the existing rule set, because they already impose changes due
to bugfixes in the rules themselves.

Change-Id: I4f2765bcd04cb50da94ac121259c0cc8244bda19
This commit is contained in:
Michael Krotscheck 2016-03-01 09:42:28 -08:00
parent c164499480
commit 1c762b4923
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
README.md
View File

@ -21,11 +21,11 @@ If you would like to contribute, please follow [OpenStack's contribution guideli
#### Rules only land with consensus #### Rules only land with consensus
Patches that activate, deactivate, or modify rules, should only be merged if a consensus of Patches that activate, deactivate, or modify rules, should only be merged if a consensus of
reviewers is reached. In this case, consensus means at least five +1 votes, with no -1 votes. Cores reviewers is reached. In this case, consensus means at least five positive votes (+1 or +2),
may not override and/or ignore -1 votes. with no -1 votes. Cores may not override and/or ignore -1 votes.
#### Library upgrades require two cores #### Library upgrades require two cores
Patches that upgrade eslint only require two core approvers to land. These patches should add new Patches that upgrade eslint only require two core approvers to land. These patches must add new
upstream rules in a deactivated state, and delete any deprecated rules. upstream rules in a deactivated state, and delete any deprecated rules.
#### Policy upgrades require all cores #### Policy upgrades require all cores