openstack/heat-dashboard
Code Issues Proposed changes

Remove unnecessary $locationProvider settings

Browse Source 
$locationProvider is not used in current implementation.
Delete related codes including unittest.

Change-Id: I1d2b3540fe151c6a06dfc037f86e33241035d003
This commit is contained in:
Xinni Ge 2017-12-01 21:55:01 +09:00
parent c135a42d80
commit 5220939cc8
2 changed files with 0 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
heat_dashboard/static/dashboard/project/heat_dashboard/template_generator/js/components/template-generator.module.js
View File

@ -13,13 +13,6 @@
.warnPalette('red') .warnPalette('red')
; ;
}]) }])
.config(['$locationProvider', function($locationProvider) {
$locationProvider.html5Mode({
enabled: true,
requireBase: false,
rewriteLinks: false,
});
}])
.config(['$provide', '$windowProvider', function($provide, $windowProvider){ .config(['$provide', '$windowProvider', function($provide, $windowProvider){
var project_window = $windowProvider.$get(); var project_window = $windowProvider.$get();
var staticPath = project_window.STATIC_URL + 'dashboard/project/heat_dashboard/template_generator/'; var staticPath = project_window.STATIC_URL + 'dashboard/project/heat_dashboard/template_generator/';

19
heat_dashboard/static/dashboard/project/heat_dashboard/template_generator/js/components/template-generator.module.spec.js
View File

@ -20,23 +20,4 @@
); );
}); });
describe('horizon.dashboard.project.heat_dashboard.template_generator $locationProvider config', function () {
var $locationProvider;
beforeEach(function () {
angular.module('locationProviderConfig', [])
.config(function(_$locationProvider_) {
$locationProvider= _$locationProvider_;
spyOn($locationProvider, 'html5Mode');
});
module('locationProviderConfig');
module('horizon.dashboard.project.heat_dashboard.template_generator');
inject();
});
it('should set html5 mode', function() {
expect($locationProvider.html5Mode)
.toHaveBeenCalledWith({ enabled: true, requireBase: false, rewriteLinks: false });
});
});
})(); })();