openstack/ironic-python-agent
Code Issues Proposed changes

avoid f-strings in logging per flake8

Browse Source 
flake8 checks recommend avoiding f-strings.

Change-Id: I1636cb45c73463b9b1d70ad784582beca277af4a
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
This commit is contained in:
Doug Goldstein 2025-01-24 13:41:44 -06:00
parent c289ac0f18
commit dfdaf09508
No known key found for this signature in database
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ironic_python_agent/disk_utils.py
View File

@ -581,8 +581,8 @@ def destroy_disk_metadata(dev, node_uuid):
raise errors.DeploymentError(
f'Destroying metadata failed on device {dev}s. Error: {e}')
LOG.info(f"Disk metadata on {dev} successfully destroyed for node "
f"{node_uuid}")
LOG.info("Disk metadata on %s successfully destroyed for node "
"%s", dev, node_uuid)
def _fix_gpt_structs(device, node_uuid):

4
ironic_python_agent/mdns.py
View File

@ -124,8 +124,8 @@ class Zeroconf(object):
f'None of addresses {all_addr} for service %('
'{service_type} are valid')
else:
LOG.warning(f'None of addresses {all_addr} seem routable, '
f'using {fallback}')
LOG.warning('None of addresses %s seem routable, '
'using %s', all_addr, fallback)
address = fallback
properties = {}

2
ironic_python_agent/utils.py
View File

@ -267,7 +267,7 @@ def unlink_without_raise(path):
if e.errno == errno.ENOENT:
return
else:
LOG.warning(f"Failed to unlink {path}, error: {e}")
LOG.warning("Failed to unlink %s, error: %s", path, e)
def _read_params_from_file(filepath):