From 114a59990360f87a97cd6e065c391f70d029a48f Mon Sep 17 00:00:00 2001 From: Peter Piela Date: Tue, 8 Nov 2016 09:21:24 -0500 Subject: [PATCH] Add a check for node last_error equal to null When retrieving a node update we check to see if the the last_error property has changed and is not empty. A test for null has been added to the empty test. Change-Id: I0c1ff8d21faecba254f21dce596ab9ef14843072 --- .../admin/ironic/node-details/node-details.controller.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ironic_ui/static/dashboard/admin/ironic/node-details/node-details.controller.js b/ironic_ui/static/dashboard/admin/ironic/node-details/node-details.controller.js index 40b42b6c..0f02e98c 100755 --- a/ironic_ui/static/dashboard/admin/ironic/node-details/node-details.controller.js +++ b/ironic_ui/static/dashboard/admin/ironic/node-details/node-details.controller.js @@ -141,10 +141,12 @@ if (lastError && ctrl.node.last_error !== "" && + ctrl.node.last_error !== null && ctrl.node.last_error !== lastError) { - toastService.add( - 'error', - "Node " + ctrl.node.name + ". " + ctrl.node.last_error); + toastService.add('error', + "Error detected on node " + + ctrl.node.name + ". " + + ctrl.node.last_error); } }); }