openstack/ironic
Code Issues Proposed changes

Remove state transition: CLEANFAIL -> CLEANING

Browse Source 
The state machine incorrectly models the transition from CLEANFAIL to
to CLEANING state. The spec [1] mentions that management of CLEANING
tasks should be handled in the same fashion as ZAPPING tasks. For
ZAPFAIL:
    Nodes that transition into ZAPFAIL will automatically enter
    maintenance mode, as failure to ZAP a machine usually indicates
    a hardware failure or something else that requires remote hands
    to fix.

Nodes in CLEANFAIL should do a similar thing as ZAPFAIL; they are
put in maintenance mode, but shouldn't be able to transition directly
to CLEANING.

This patch also clarifies the documentation for the transition
CLEANFAIL -> MANAGEABLE.

[1] http://specs.openstack.org/openstack/ironic-specs/specs/kilo/new-ironic-state-machine.html#proposed-change

Change-Id: Ieda2fcd78332a063c51685cd01bb824014f0f4a8
Closes-Bug: #1446758
This commit is contained in:
Ruby Loo 2015-04-21 19:07:32 +00:00
parent 6f36e056d4
commit 0c295153af
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ironic/common/states.py
View File

@ -262,11 +262,8 @@ machine.add_transition(CLEANING, AVAILABLE, 'done')
# If cleaning fails, wait for operator intervention
machine.add_transition(CLEANING, CLEANFAIL, 'fail')
# A node that fails cleaning may be put back through cleaning
machine.add_transition(CLEANFAIL, CLEANING, 'clean')
# An operator may want to hold a CLEANFAIL node in operator for zapping or
# outside-of-Ironic operations (like replacing hardware)
# An operator may want to move a CLEANFAIL node to MANAGEABLE, to perform
# other actions like zapping
machine.add_transition(CLEANFAIL, MANAGEABLE, 'manage')
# From MANAGEABLE, a node may move to available after going through cleaning