openstack/ironic
Code Issues Proposed changes

Merge "Add error logging on lookup failures in the API"

Browse Source
This commit is contained in:
Zuul 2023-04-04 12:35:28 +00:00 committed by Gerrit Code Review
commit 17cabc4b81
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ironic/api/controllers/v1/ramdisk.py
View File

@ -131,13 +131,17 @@ class LookupController(rest.RestController):
else:
node = objects.Node.get_by_port_addresses(
api.request.context, valid_addresses)
except exception.NotFound:
except exception.NotFound as e:
# NOTE(dtantsur): we are reraising the same exception to make sure
# we don't disclose the difference between nodes that are not found
# at all and nodes in a wrong state by different error messages.
LOG.error('No node has been found during lookup: %s', e)
raise exception.NotFound()
if CONF.api.restrict_lookup and not self.lookup_allowed(node):
LOG.error('Lookup is not allowed for node %(node)s in the '
'provision state %(state)s',
{'node': node.uuid, 'state': node.provision_state})
raise exception.NotFound()
if api_utils.allow_agent_token():