openstack/ironic
Code Issues Proposed changes

Merge "Fix invalid assertTrue which should be assertEqual"

Browse Source
This commit is contained in:
Zuul 2020-07-29 17:29:51 +00:00 committed by Gerrit Code Review
commit 52160b5bfe
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ironic/tests/unit/drivers/modules/irmc/test_boot.py
View File

@ -947,7 +947,7 @@ class IRMCVirtualMediaBootTestCase(test_common.BaseIRMCTest):
task.node.driver_internal_info = {'is_whole_disk_image': True} task.node.driver_internal_info = {'is_whole_disk_image': True}
task.driver.boot.validate(task) task.driver.boot.validate(task)
self.assertTrue(check_share_fs_mounted_mock.call_count, 2) self.assertEqual(check_share_fs_mounted_mock.call_count, 2)
deploy_info_mock.assert_called_once_with(task.node) deploy_info_mock.assert_called_once_with(task.node)
self.assertFalse(is_glance_image_mock.called) self.assertFalse(is_glance_image_mock.called)
validate_prop_mock.assert_called_once_with(task.context, validate_prop_mock.assert_called_once_with(task.context,
@ -971,7 +971,7 @@ class IRMCVirtualMediaBootTestCase(test_common.BaseIRMCTest):
shared=False) as task: shared=False) as task:
task.driver.boot.validate(task) task.driver.boot.validate(task)
self.assertTrue(check_share_fs_mounted_mock.call_count, 2) self.assertEqual(check_share_fs_mounted_mock.call_count, 2)
deploy_info_mock.assert_called_once_with(task.node) deploy_info_mock.assert_called_once_with(task.node)
validate_prop_mock.assert_called_once_with( validate_prop_mock.assert_called_once_with(
task.context, d_info, ['kernel_id', 'ramdisk_id']) task.context, d_info, ['kernel_id', 'ramdisk_id'])
@ -994,7 +994,7 @@ class IRMCVirtualMediaBootTestCase(test_common.BaseIRMCTest):
shared=False) as task: shared=False) as task:
task.driver.boot.validate(task) task.driver.boot.validate(task)
self.assertTrue(check_share_fs_mounted_mock.call_count, 2) self.assertEqual(check_share_fs_mounted_mock.call_count, 2)
deploy_info_mock.assert_called_once_with(task.node) deploy_info_mock.assert_called_once_with(task.node)
validate_prop_mock.assert_called_once_with( validate_prop_mock.assert_called_once_with(
task.context, d_info, ['kernel', 'ramdisk']) task.context, d_info, ['kernel', 'ramdisk'])