From 5839bbad3993790bdfe4d901b36bb816461b3934 Mon Sep 17 00:00:00 2001 From: Julia Kreger Date: Tue, 8 May 2018 12:42:34 -0700 Subject: [PATCH] Silence F405 errors The F405 errors that were present in our repository are a common pattern for ansible modules. As such, They have been marked for noqa. Change-Id: Ie161bf38b00f5e798a470b16700925f9ef7b322d Story: #2001985 --- ironic/drivers/modules/ansible/playbooks/library/facts_wwn.py | 2 +- .../drivers/modules/ansible/playbooks/library/root_hints.py | 2 +- .../drivers/modules/ansible/playbooks/library/stream_url.py | 2 +- tox.ini | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/ironic/drivers/modules/ansible/playbooks/library/facts_wwn.py b/ironic/drivers/modules/ansible/playbooks/library/facts_wwn.py index 7703f570c1..f67ce270dc 100644 --- a/ironic/drivers/modules/ansible/playbooks/library/facts_wwn.py +++ b/ironic/drivers/modules/ansible/playbooks/library/facts_wwn.py @@ -47,7 +47,7 @@ def get_devices_wwn(devices, module): def main(): - module = AnsibleModule( + module = AnsibleModule( # noqa This is normal for Ansible modules. argument_spec=dict( devices=dict(required=True, type='list'), ), diff --git a/ironic/drivers/modules/ansible/playbooks/library/root_hints.py b/ironic/drivers/modules/ansible/playbooks/library/root_hints.py index 32473eb77b..eeb9b7e687 100644 --- a/ironic/drivers/modules/ansible/playbooks/library/root_hints.py +++ b/ironic/drivers/modules/ansible/playbooks/library/root_hints.py @@ -61,7 +61,7 @@ def root_hint(hints, devices): def main(): - module = AnsibleModule( + module = AnsibleModule( # noqa This is normal for Ansible modules. argument_spec=dict( root_device_hints=dict(required=True, type='dict'), ansible_devices=dict(required=True, type='dict'), diff --git a/ironic/drivers/modules/ansible/playbooks/library/stream_url.py b/ironic/drivers/modules/ansible/playbooks/library/stream_url.py index dd750d6378..957568b068 100644 --- a/ironic/drivers/modules/ansible/playbooks/library/stream_url.py +++ b/ironic/drivers/modules/ansible/playbooks/library/stream_url.py @@ -60,7 +60,7 @@ def stream_to_dest(url, dest, chunksize, hash_algo, verify=True, certs=None): def main(): - module = AnsibleModule( + module = AnsibleModule( # noqa This is normal for Ansible modules. argument_spec=dict( url=dict(required=True, type='str'), dest=dict(required=True, type='str'), diff --git a/tox.ini b/tox.ini index 27b06ec3e3..e838a0e6ec 100644 --- a/tox.ini +++ b/tox.ini @@ -106,9 +106,9 @@ commands = {posargs} [flake8] # [W503] Line break before binary operator. -# NOTE(TheJulia): Adding W606,E501,F405 to the ignore list +# NOTE(TheJulia): Adding W606,E501 to the ignore list # until we are able to clean them up in the code base. -ignore = E129,W503,W606,E501,F405 +ignore = E129,W503,W606,E501 filename = *.py,app.wsgi exclude = .venv,.git,.tox,dist,doc,*lib/python*,*egg,build import-order-style = pep8