openstack/ironic
Code Issues Proposed changes

Stop configuring install_command in tox.

Browse Source 
Currently, we are overriding 'install_command' to use 'pip'. This is
considered poor behavior and 'python -m pip' should be used instead:

https://snarky.ca/why-you-should-use-python-m-pip/

It turns out that this is the the default value provided by tox:

https://tox.readthedocs.io/en/latest/config.html#conf-install_command

So we can remove the line and simply use the default value.

openstack-discuss thread
http://lists.openstack.org/pipermail/openstack-discuss/2020-April/014237.html

Bumping  in requirements:
-alembic to 0.9.6
-keystoneauth1 to 3.18

Bumping libs in  in l-c:
-alembic to 0.9.6
-keystoneauth1 to 3.18
-pika to 0.10.0 (necessary for installation)

Change-Id: I059e841ab891ba0451d0423065e9727c8c77f337
This commit is contained in:
Iury Gregory Melo Ferreira 2020-04-17 19:52:08 +02:00
parent 7a402c5858
commit 6397777ea8
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lower-constraints.txt
View File

@ -1,4 +1,4 @@
alembic==0.8.10 alembic==0.9.6
automaton==1.9.0 automaton==1.9.0
Babel==2.3.4 Babel==2.3.4
bandit==1.1.0 bandit==1.1.0
@ -16,7 +16,7 @@ iso8601==0.1.11
Jinja2==2.10 Jinja2==2.10
jsonpatch==1.16 jsonpatch==1.16
jsonschema==2.6.0 jsonschema==2.6.0
keystoneauth1==3.15.0 keystoneauth1==3.18.0
keystonemiddleware==4.17.0 keystonemiddleware==4.17.0
mock==3.0.0 mock==3.0.0
openstackdocstheme==1.31.2 openstackdocstheme==1.31.2
@ -43,6 +43,7 @@ oslotest==3.2.0
osprofiler==1.5.0 osprofiler==1.5.0
pbr==2.0.0 pbr==2.0.0
pecan==1.0.0 pecan==1.0.0
pika==0.10.0
psutil==3.2.2 psutil==3.2.2
psycopg2==2.7.3 psycopg2==2.7.3
Pygments==2.2.0 Pygments==2.2.0

4
requirements.txt
View File

@ -3,14 +3,14 @@
# process, which may cause wedges in the gate later. # process, which may cause wedges in the gate later.
pbr!=2.1.0,>=2.0.0 # Apache-2.0 pbr!=2.1.0,>=2.0.0 # Apache-2.0
SQLAlchemy!=1.1.5,!=1.1.6,!=1.1.7,!=1.1.8,>=1.0.10 # MIT SQLAlchemy!=1.1.5,!=1.1.6,!=1.1.7,!=1.1.8,>=1.0.10 # MIT
alembic>=0.8.10 # MIT alembic>=0.9.6 # MIT
automaton>=1.9.0 # Apache-2.0 automaton>=1.9.0 # Apache-2.0
eventlet!=0.18.3,!=0.20.1,>=0.18.2 # MIT eventlet!=0.18.3,!=0.20.1,>=0.18.2 # MIT
WebOb>=1.7.1 # MIT WebOb>=1.7.1 # MIT
python-cinderclient!=4.0.0,>=3.3.0 # Apache-2.0 python-cinderclient!=4.0.0,>=3.3.0 # Apache-2.0
python-neutronclient>=6.7.0 # Apache-2.0 python-neutronclient>=6.7.0 # Apache-2.0
python-glanceclient>=2.8.0 # Apache-2.0 python-glanceclient>=2.8.0 # Apache-2.0
keystoneauth1>=3.15.0 # Apache-2.0 keystoneauth1>=3.18.0 # Apache-2.0
ironic-lib>=2.17.1 # Apache-2.0 ironic-lib>=2.17.1 # Apache-2.0
python-swiftclient>=3.2.0 # Apache-2.0 python-swiftclient>=3.2.0 # Apache-2.0
pytz>=2013.6 # MIT pytz>=2013.6 # MIT

1
tox.ini
View File

@ -6,7 +6,6 @@ ignore_basepython_conflict=true
[testenv] [testenv]
usedevelop = True usedevelop = True
install_command = pip install -U {opts} {packages}
basepython = python3 basepython = python3
setenv = VIRTUAL_ENV={envdir} setenv = VIRTUAL_ENV={envdir}
PYTHONDONTWRITEBYTECODE = 1 PYTHONDONTWRITEBYTECODE = 1