openstack/ironic
Code Issues Proposed changes

Remove deleted[_at] from base object.

Browse Source 
Ironic is not using soft-deletion, and since the database models do not
have the deleted or deleted_at fields, neither should the objects.

Change-Id: I152366e75d5d3b0c25eb509db91f411bcc04c6f6
This commit is contained in:
Devananda van der Veen 2013-06-07 15:48:04 -07:00
parent fe6896b1bb
commit 65e0349786
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ironic/objects/base.py
View File

@ -177,8 +177,6 @@ class IronicObject(object):
fields = {
'created_at': obj_utils.datetime_or_none,
'updated_at': obj_utils.datetime_or_none,
'deleted_at': obj_utils.datetime_or_none,
'deleted': int,
}
def __init__(self):

5
ironic/tests/objects/test_objects.py
View File

@ -358,16 +358,15 @@ class _TestObject(object):
obj = MyObj()
obj.created_at = dt
obj.updated_at = dt
obj.deleted_at = None
expected = {'ironic_object.name': 'MyObj',
'ironic_object.namespace': 'ironic',
'ironic_object.version': '1.5',
'ironic_object.changes':
['created_at', 'deleted_at', 'updated_at'],
['created_at', 'updated_at'],
'ironic_object.data':
{'created_at': timeutils.isotime(dt),
'updated_at': timeutils.isotime(dt),
'deleted_at': None}
}
}
self.assertEqual(obj.obj_to_primitive(), expected)