openstack/ironic
Code Issues Proposed changes

Merge "Make deploy step failure logging indicate the error"

Browse Source
This commit is contained in:
Zuul 2020-04-02 13:04:47 +00:00 committed by Gerrit Code Review
commit 6798715eaf
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ironic/conductor/deployments.py
View File

@ -257,7 +257,10 @@ def do_next_deploy_step(task, step_index, conductor_id):
{'node': node.uuid, 'step': node.deploy_step, 'err': e})
utils.deploying_error_handler(
task, log_msg,
_("Failed to deploy: %s") % node.deploy_step)
_("Failed to deploy: Deploy step %(step)s, "
"error: %(err)s.") % {
'step': node.deploy_step,
'err': e})
return
except Exception as e:
log_msg = ('Node %(node)s failed deploy step %(step)s with '

6
releasenotes/notes/deploy-step-error-d343e8cb7d1b2305.yaml Normal file
View File

@ -0,0 +1,6 @@
---
fixes:
- |
Fixes vague node ``last_error`` field reporting upon deploy step
failure by providing the exception error message in addition
to the step that failed.