openstack/ironic
Code Issues Proposed changes

Merge "Follow-up patch for One Button Secure Erase clean step"

Browse Source
This commit is contained in:
Zuul 2020-09-14 08:27:54 +00:00 committed by Gerrit Code Review
commit 72baa1da58
2 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
doc/source/admin/drivers/ilo.rst
View File

@ -2052,7 +2052,7 @@ Below are the steps to perform this clean step:
.. code-block:: console .. code-block:: console
openstack baremetal node clean test_node --clean-steps\ openstack baremetal node clean $node_ident --clean-steps\
'[{"interface": "management", "step": "one_button_secure_erase"}]' '[{"interface": "management", "step": "one_button_secure_erase"}]'
* Once the clean step would triggered and node go to 'clean wait' state and * Once the clean step would triggered and node go to 'clean wait' state and
@ -2060,7 +2060,7 @@ Below are the steps to perform this clean step:
.. code-block:: console .. code-block:: console
openstack baremetal node delete test_node openstack baremetal node delete $node_ident
.. note:: .. note::
* Even after deleting the node, One Button Secure Erase operation would continue * Even after deleting the node, One Button Secure Erase operation would continue
@ -2071,7 +2071,7 @@ Below are the steps to perform this clean step:
* One Button Secure Erase should be used with extreme caution, and only when a system * One Button Secure Erase should be used with extreme caution, and only when a system
is being decommissioned. During the erase the iLO network would keep disconnecting is being decommissioned. During the erase the iLO network would keep disconnecting
and after the erase user will completly lose iLO access along with the credentials and after the erase user will completely lose iLO access along with the credentials
of the server, which needs to be regained by the administrator. The process can take of the server, which needs to be regained by the administrator. The process can take
up to a day or two to fully erase and reset all user data. up to a day or two to fully erase and reset all user data.

9
ironic/drivers/modules/ilo/management.py
View File

@ -941,7 +941,7 @@ class Ilo5Management(IloManagement):
The One-button secure erase process resets iLO and deletes all licenses The One-button secure erase process resets iLO and deletes all licenses
stored there, resets BIOS settings, and deletes all Active Health stored there, resets BIOS settings, and deletes all Active Health
System (AHS) and warranty data stored on the system. It also erases System (AHS) and warranty data stored on the system. It also erases
supported non-volatile storage data and deletes any deployment settings supported non-volatile storage data and deletes any deployment setting
profiles. profiles.
:param task: a TaskManager instance. :param task: a TaskManager instance.
@ -956,7 +956,12 @@ class Ilo5Management(IloManagement):
manager_utils.node_power_action(task, states.REBOOT) manager_utils.node_power_action(task, states.REBOOT)
node.maintenance = True node.maintenance = True
node.maintenance_reason = ( node.maintenance_reason = (
"Running one button secure erase clean step.") "One Button Secure erase clean step has begun, it will wipe "
"data from drives and any non-volatile/persistent storage, "
"reset iLO and delete all licenses stored there, reset BIOS "
"settings, delete Active Health System (AHS) and warranty "
"data stored in the system and delete any deployment settings "
"profiles.")
node.save() node.save()
return states.CLEANWAIT return states.CLEANWAIT
except ilo_error.IloError as ilo_exception: except ilo_error.IloError as ilo_exception: