From 7e825a28c0a049c38567bb44dc316def562fc25c Mon Sep 17 00:00:00 2001 From: Julia Kreger Date: Mon, 20 Jan 2020 09:25:42 -0800 Subject: [PATCH] Deprecate ibmc The ibmc hardware type and related code is no longer being tested in third party CI. No party has stepped up to continue maintaining and supporting this code. As such, our standard practice is to deprecate and remove the driver code. Change-Id: I8e16d8a2f68623f98ae5e3acce886b29f95eacb5 Story: 2007185 Task: 38310 --- doc/source/admin/drivers/ibmc.rst | 4 ++++ ironic/drivers/ibmc.py | 2 ++ ironic/drivers/modules/ibmc/management.py | 2 ++ ironic/drivers/modules/ibmc/power.py | 2 ++ ironic/drivers/modules/ibmc/vendor.py | 2 ++ .../notes/deprecate-ibmc-9106cc3a81171738.yaml | 11 +++++++++++ 6 files changed, 23 insertions(+) create mode 100644 releasenotes/notes/deprecate-ibmc-9106cc3a81171738.yaml diff --git a/doc/source/admin/drivers/ibmc.rst b/doc/source/admin/drivers/ibmc.rst index 6ed01f3f79..c39bf05df7 100644 --- a/doc/source/admin/drivers/ibmc.rst +++ b/doc/source/admin/drivers/ibmc.rst @@ -2,6 +2,10 @@ iBMC driver =============== +.. warning:: + The ``ibmc`` driver has been deprecated due to a lack of a functioning + third party CI and will be removed in the Victoria development cycle. + Overview ======== diff --git a/ironic/drivers/ibmc.py b/ironic/drivers/ibmc.py index 0f9ae5a5bf..bbee2ce614 100644 --- a/ironic/drivers/ibmc.py +++ b/ironic/drivers/ibmc.py @@ -25,6 +25,8 @@ from ironic.drivers.modules import noop class IBMCHardware(generic.GenericHardware): """Huawei iBMC hardware type.""" + supported = False + @property def supported_management_interfaces(self): """List of supported management interfaces.""" diff --git a/ironic/drivers/modules/ibmc/management.py b/ironic/drivers/modules/ibmc/management.py index 672501a7b5..3596b391be 100644 --- a/ironic/drivers/modules/ibmc/management.py +++ b/ironic/drivers/modules/ibmc/management.py @@ -34,6 +34,8 @@ LOG = log.getLogger(__name__) class IBMCManagement(base.ManagementInterface): + supported = False + def __init__(self): """Initialize the iBMC management interface diff --git a/ironic/drivers/modules/ibmc/power.py b/ironic/drivers/modules/ibmc/power.py index 6bb15ee222..0750ffa41b 100644 --- a/ironic/drivers/modules/ibmc/power.py +++ b/ironic/drivers/modules/ibmc/power.py @@ -40,6 +40,8 @@ EXPECT_POWER_STATE_MAP = { class IBMCPower(base.PowerInterface): + supported = False + def __init__(self): """Initialize the iBMC power interface. diff --git a/ironic/drivers/modules/ibmc/vendor.py b/ironic/drivers/modules/ibmc/vendor.py index 24d497cf72..2d4f74a280 100644 --- a/ironic/drivers/modules/ibmc/vendor.py +++ b/ironic/drivers/modules/ibmc/vendor.py @@ -29,6 +29,8 @@ LOG = log.getLogger(__name__) class IBMCVendor(base.VendorInterface): + supported = False + def __init__(self): """Initialize the iBMC vendor interface. diff --git a/releasenotes/notes/deprecate-ibmc-9106cc3a81171738.yaml b/releasenotes/notes/deprecate-ibmc-9106cc3a81171738.yaml new file mode 100644 index 0000000000..526d2fc866 --- /dev/null +++ b/releasenotes/notes/deprecate-ibmc-9106cc3a81171738.yaml @@ -0,0 +1,11 @@ +--- +deprecations: + - | + The ``ibmc`` hardware type has been deprecated. While the Huawei team + setup Third-Party CI for the driver's inclusion into ironic, the CI + unfortunately went down around the time the United States of America + announced commerce restrictions against Huawei. + + Unfortunantely, without third party CI and no contacts to maintain the + driver, the ironic community is left with little choice but to deprecate + and ultimately remove the driver.