openstack/ironic
Code Issues Proposed changes

Remove autocommit, again.

Browse Source 
Patch Ic8b1d964f7be5784e01c89bfb6c0277ea82eec2d was developed
without the autocommit change in place, which should allow
Ironic to operate properly with sqlite, in a single process
standalone mode.

As such, we shouldn't need to keep autocommit turned on, but
we may need to put it back if we identify yet another issue,
which is entirely possible with major database refactors.

Change-Id: Icde231e9db3b7a9f59205505cd51a4064e41d746
This commit is contained in:
Julia Kreger 2022-10-27 10:08:19 -07:00
parent 75b881bd31
commit c03a5b44ef
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ironic/db/sqlalchemy/__init__.py
View File

@ -17,10 +17,8 @@ from sqlalchemy import event
CONF = cfg.CONF
# FIXME(stephenfin): we need to remove reliance on autocommit semantics ASAP
# since it's not compatible with SQLAlchemy 2.0
# NOTE(dtantsur): we want sqlite as close to a real database as possible.
enginefacade.configure(sqlite_fk=True, __autocommit=True)
enginefacade.configure(sqlite_fk=True)
# NOTE(TheJulia): Setup a listener to trigger the sqlite write-ahead