openstack/ironic
Code Issues Proposed changes

Add more unit tests for NO_PROXY validation

Browse Source 
This commit adds some more tests for no_proxy validity as it was
suggested in the last patchset of
30125908f669ba270f33a487803eaf584d7670fc

Change-Id: I3443d1a2deac9494f1cf80fecbcbb12391ffeeb4
This commit is contained in:
Vladyslav Drok 2016-01-19 20:14:40 +02:00
parent a74f8169d5
commit cb5c5001f1
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ironic/tests/unit/common/test_utils.py
View File

@ -447,10 +447,15 @@ class GenericUtilsTestCase(base.TestCase):
proxy8 = 'c.-a.com'
proxy9 = 'c.a-.com'
proxy10 = ',,example.com:3128,'
valid_with_whitespaces = ' , '.join([proxy0, proxy1, proxy5, proxy10])
all_valid = ','.join([proxy0, proxy1, proxy5, proxy10])
proxy11 = '192.168.1.1' # IP should be valid
proxy12 = '' # empty string should also be valid
valid_with_whitespaces = ' , '.join(
[proxy0, proxy1, proxy5, proxy10, proxy11]
)
all_valid = ','.join([proxy0, proxy1, proxy5, proxy10, proxy11])
self.assertTrue(utils.is_valid_no_proxy(all_valid))
self.assertTrue(utils.is_valid_no_proxy(valid_with_whitespaces))
self.assertTrue(utils.is_valid_no_proxy(proxy12))
self.assertFalse(utils.is_valid_no_proxy(proxy2))
self.assertFalse(utils.is_valid_no_proxy(proxy3))
self.assertFalse(utils.is_valid_no_proxy(proxy4))