openstack/ironic
Code Issues Proposed changes

Remove unused state transitions

Browse Source 
This removes the following state transitions from our
state machine because they aren't transitions that are
implemented by our conductor or drivers. Currently,
nodes in these (provision) states never transition to
ERROR:

-machine.add_transition(NOSTATE, ERROR, 'error')
-machine.add_transition(DEPLOYING, ERROR, 'error')
-machine.add_transition(ACTIVE, ERROR, 'error')

Change-Id: Id7870a662f68496f9789b4b6bef0efecd68dbf68
Related-to: blueprint new-ironic-state-machine
This commit is contained in:
Ruby Loo 2015-01-15 23:07:38 +00:00
parent 9b1e2cf6c2
commit d239273e96
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ironic/common/states.py
View File

@ -187,10 +187,7 @@ machine.add_transition(DEPLOYFAIL, DELETING, 'delete')
# A delete may complete
machine.add_transition(DELETING, NOSTATE, 'done')
# These states can also transition to error
machine.add_transition(NOSTATE, ERROR, 'error')
machine.add_transition(DEPLOYING, ERROR, 'error')
machine.add_transition(ACTIVE, ERROR, 'error')
# This state can also transition to error
machine.add_transition(DELETING, ERROR, 'error')
# An errored instance can be rebuilt