openstack/ironic
Code Issues Proposed changes

Change assertTrue(isinstance()) by optimal assert

Browse Source 
Some of tests use different method of assertTrue(isinstance(A, B)) or
assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
B) provided by testtools.

Change-Id: I79ae67c2509cfeac6e7c53257dc4f26715fb9012
Closes-bug: #1268480
This commit is contained in:
Shuquan Huang 2015-12-30 22:27:11 +08:00
parent 3732114d5c
commit dd8884123a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ironic/tests/unit/conductor/test_manager.py
View File

@ -1909,7 +1909,7 @@ class MiscTestCase(mgr_utils.ServiceSetUpMixin, mgr_utils.CommonMixIn,
def test_get_driver_known(self):
self._start_service()
driver = self.service._get_driver('fake')
self.assertTrue(isinstance(driver, drivers_base.BaseDriver))
self.assertIsInstance(driver, drivers_base.BaseDriver)
def test_get_driver_unknown(self):
self._start_service()