openstack/ironic
Code Issues Proposed changes

Cleanup unused conf variables

Browse Source 
I noticed in nova that we had a lot of unused conf variables. I
wondered if this was a thing in other projects as well. Turns out
it is.

Change-Id: Ic1c4f911c9760811aea61e0150fa69987ea08e29
This commit is contained in:
Michael Still 2016-02-16 16:18:57 +11:00
parent 9996949e8e
commit e995881f23
13 changed files with 1 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ironic/drivers/modules/ilo/vendor.py
View File

@ -15,7 +15,6 @@
Vendor Interface for iLO drivers and its supporting methods.
"""
from oslo_config import cfg
from oslo_log import log as logging
from ironic.common import exception
@ -31,8 +30,6 @@ from ironic.drivers.modules import iscsi_deploy
LOG = logging.getLogger(__name__)
CONF = cfg.CONF
class IloVirtualMediaAgentVendorInterface(agent.AgentVendorInterface):
"""Interface for vendor passthru related actions."""

3
ironic/drivers/modules/irmc/power.py
View File

@ -15,7 +15,6 @@
"""
iRMC Power Driver using the Base Server Profile
"""
from oslo_config import cfg
from oslo_log import log as logging
from oslo_utils import importutils
@ -32,8 +31,6 @@ from ironic.drivers.modules.irmc import common as irmc_common
scci = importutils.try_import('scciclient.irmc.scci')
CONF = cfg.CONF
LOG = logging.getLogger(__name__)
if scci:

2
ironic/tests/unit/common/test_swift.py
View File

@ -13,7 +13,6 @@
# under the License.
import mock
from oslo_config import cfg
import six
from six.moves import builtins as __builtin__
from six.moves import http_client
@ -25,7 +24,6 @@ from ironic.common import exception
from ironic.common import swift
from ironic.tests import base
CONF = cfg.CONF
if six.PY3:
import io

2
ironic/tests/unit/drivers/modules/amt/test_management.py
View File

@ -16,7 +16,6 @@ Test class for AMT ManagementInterface
"""
import mock
from oslo_config import cfg
from ironic.common import boot_devices
from ironic.common import exception
@ -33,7 +32,6 @@ from ironic.tests.unit.drivers import third_party_driver_mock_specs \
from ironic.tests.unit.objects import utils as obj_utils
INFO_DICT = db_utils.get_test_amt_info()
CONF = cfg.CONF
@mock.patch.object(amt_common, 'pywsman', spec_set=mock_specs.PYWSMAN_SPEC)

2
ironic/tests/unit/drivers/modules/ilo/test_console.py
View File

@ -16,7 +16,6 @@
"""Test class for common methods used by iLO modules."""
import mock
from oslo_config import cfg
import six
from ironic.common import exception
@ -34,7 +33,6 @@ if six.PY3:
file = io.BytesIO
INFO_DICT = db_utils.get_test_ilo_info()
CONF = cfg.CONF
class IloConsoleInterfaceTestCase(db_base.DbTestCase):

2
ironic/tests/unit/drivers/modules/ilo/test_deploy.py
View File

@ -16,7 +16,6 @@
"""Test class for deploy methods used by iLO modules."""
import mock
from oslo_config import cfg
import six
from ironic.common import boot_devices
@ -41,7 +40,6 @@ if six.PY3:
file = io.BytesIO
INFO_DICT = db_utils.get_test_ilo_info()
CONF = cfg.CONF
class IloDeployPrivateMethodsTestCase(db_base.DbTestCase):

2
ironic/tests/unit/drivers/modules/ilo/test_inspect.py
View File

@ -16,7 +16,6 @@
"""Test class for Management Interface used by iLO modules."""
import mock
from oslo_config import cfg
import six
from ironic.common import exception
@ -35,7 +34,6 @@ from ironic.tests.unit.objects import utils as obj_utils
INFO_DICT = db_utils.get_test_ilo_info()
CONF = cfg.CONF
class IloInspectTestCase(db_base.DbTestCase):

2
ironic/tests/unit/drivers/modules/ilo/test_management.py
View File

@ -15,7 +15,6 @@
"""Test class for Management Interface used by iLO modules."""
import mock
from oslo_config import cfg
from oslo_utils import importutils
from ironic.common import boot_devices
@ -32,7 +31,6 @@ from ironic.tests.unit.objects import utils as obj_utils
ilo_error = importutils.try_import('proliantutils.exception')
INFO_DICT = db_utils.get_test_ilo_info()
CONF = cfg.CONF
class IloManagementTestCase(db_base.DbTestCase):

2
ironic/tests/unit/drivers/modules/ilo/test_vendor.py
View File

@ -16,7 +16,6 @@
"""Test class for vendor methods used by iLO modules."""
import mock
from oslo_config import cfg
from ironic.common import exception
from ironic.common import states
@ -34,7 +33,6 @@ from ironic.tests.unit.objects import utils as obj_utils
INFO_DICT = db_utils.get_test_ilo_info()
CONF = cfg.CONF
class VendorPassthruTestCase(db_base.DbTestCase):

3
ironic/tests/unit/drivers/modules/irmc/test_power.py
View File

@ -17,7 +17,7 @@ Test class for iRMC Power Driver
"""
import mock
from oslo_config import cfg
from oslo_utils import uuidutils
from ironic.common import exception
@ -32,7 +32,6 @@ from ironic.tests.unit.db import utils as db_utils
from ironic.tests.unit.objects import utils as obj_utils
INFO_DICT = db_utils.get_test_irmc_info()
CONF = cfg.CONF
@mock.patch.object(irmc_common, 'get_irmc_client', spec_set=True,

3
ironic/tests/unit/drivers/modules/test_virtualbox.py
View File

@ -13,7 +13,6 @@
"""Test class for VirtualBox Driver Modules."""
import mock
from oslo_config import cfg
from pyremotevbox import exception as pyremotevbox_exc
from pyremotevbox import vbox as pyremotevbox_vbox
@ -34,8 +33,6 @@ INFO_DICT = {
'virtualbox_port': 12345,
}
CONF = cfg.CONF
class VirtualBoxMethodsTestCase(db_base.DbTestCase):

2
ironic/tests/unit/drivers/modules/ucs/test_helper.py
View File

@ -15,7 +15,6 @@
"""Test class for common methods used by UCS modules."""
import mock
from oslo_config import cfg
from oslo_utils import importutils
from ironic.common import exception
@ -30,7 +29,6 @@ from ironic.tests.unit.objects import utils as obj_utils
ucs_error = importutils.try_import('UcsSdk.utils.exception')
INFO_DICT = db_utils.get_test_ucs_info()
CONF = cfg.CONF
class UcsValidateParametersTestCase(db_base.DbTestCase):

2
ironic/tests/unit/drivers/modules/ucs/test_management.py
View File

@ -17,7 +17,6 @@ Test class for UCS ManagementInterface
"""
import mock
from oslo_config import cfg
from oslo_utils import importutils
from ironic.common import boot_devices
@ -33,7 +32,6 @@ from ironic.tests.unit.objects import utils as obj_utils
ucs_error = importutils.try_import('UcsSdk.utils.exception')
INFO_DICT = db_utils.get_test_ucs_info()
CONF = cfg.CONF
class UcsManagementTestCase(db_base.DbTestCase):