From fdc6424de3ad4beeeb95d348f422af00e03d1892 Mon Sep 17 00:00:00 2001 From: Julia Kreger Date: Tue, 23 Nov 2021 08:13:35 -0800 Subject: [PATCH] Clarify driver load error message The NoValidDefaultForInterface exception is a little misleading in that if one doesn't have the base interface enabled, and they attempt to enable a hardware type which requires or only supports disabled interfaces, they will also get an exeption. The reality is we need to suggest for them to look at enabling the interfaces before looking at the default interface overrides, because logically the brain jumps to setting a default before checking the interface settings. Change-Id: I50d4381e11da96cb7ae0ee8cbda18534380bd471 --- ironic/common/exception.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ironic/common/exception.py b/ironic/common/exception.py index 1f19d6e6b8..9d9420f9d2 100644 --- a/ironic/common/exception.py +++ b/ironic/common/exception.py @@ -245,7 +245,8 @@ class NoValidDefaultForInterface(InvalidParameterValue): # because node_info could be an empty string. If node_info # is not empty, it should start with a space. _msg_fmt = _("For%(node_info)s hardware type '%(driver)s', no default " - "value found for %(interface_type)s interface.") + "value found for %(interface_type)s interface could be " + "determined. Please ensure the interfaces are enabled.") class ImageNotFound(NotFound):