diff --git a/ironic/api/controllers/v1/node.py b/ironic/api/controllers/v1/node.py index ece70cd164..f9c651ca92 100644 --- a/ironic/api/controllers/v1/node.py +++ b/ironic/api/controllers/v1/node.py @@ -1278,7 +1278,7 @@ def _check_steps(steps, step_type, schema): for step in steps: eocn = step.get('execute_on_child_nodes') child_nodes = step.get('limit_child_node_execution') - if eocn and type(child_nodes) == list: + if eocn and isinstance(child_nodes, list): # Extract each element, validate permission to access node. for entry in child_nodes: if not uuidutils.is_uuid_like(entry): diff --git a/tox.ini b/tox.ini index 09a96b957e..64974e4378 100644 --- a/tox.ini +++ b/tox.ini @@ -41,12 +41,12 @@ commands = {toxinidir}/tools/states_to_dot.py -f {toxinidir}/doc/source/images/s [testenv:pep8] usedevelop = False deps= - hacking~=6.0.0 # Apache-2.0 - doc8>=0.6.0 # Apache-2.0 + hacking~=6.1.0 # Apache-2.0 + doc8~=1.1.0 # Apache-2.0 pycodestyle>=2.0.0,<3.0.0 # MIT - flake8-import-order>=0.17.1 # LGPLv3 - Pygments>=2.2.0 # BSD - bashate>=0.5.1 # Apache-2.0 + flake8-import-order~=0.18.0 # LGPLv3 + Pygments~=2.17.0 # BSD + bashate~=2.1.0 # Apache-2.0 allowlist_externals = bash {toxinidir}/tools/run_bashate.sh {toxinidir}/tools/check-releasenotes.py