openstack/kayobe
Code Issues Proposed changes

Fix empty kolla_overcloud_inventory_storage_groups

Browse Source 
In some cases we may have a kolla group defined in
'kolla_overcloud_inventory_top_level_group_map' which has no kayobe
groups mapped to it. This causes no entry to be added to the inventory
for the group.  If the group is referenced elsewhere in the inventory,
then Ansible will fail to parse the inventory file.

The specific case that failed was when setting
'kolla_overcloud_inventory_storage_groups' to an empty list.

This change ensures that we add an empty definition for the group in the
kolla inventory.

Change-Id: I8e797aa6c55f8cf0cf6d52a33f213d8131581fea
Story: 2002105
Task: 19783
This commit is contained in:
Mark Goddard 2018-05-25 12:27:46 +01:00
parent 1b8c98ff24
commit 22c155349f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ansible/roles/kolla-ansible/templates/overcloud-top-level.j2
View File

@ -60,7 +60,7 @@ ansible_python_interpreter={{ kolla_ansible_target_venv }}/bin/python
{% endif %} {% endif %}
{% endfor %} {% endfor %}
{% for group in kolla_overcloud_inventory_kolla_top_level_groups %} {% for group in kolla_overcloud_inventory_kolla_top_level_groups %}
{% if group not in kolla_overcloud_inventory_top_level_group_map %} {% if not kolla_overcloud_inventory_top_level_group_map.get(group, {}).get('groups') %}
# Empty group definition for {{ group }}. # Empty group definition for {{ group }}.
[{{ group }}] [{{ group }}]