openstack/kayobe
Code Issues Proposed changes

Merge "Performance: skip LVM configuration if no groups configured"

Browse Source
This commit is contained in:
Zuul 2020-09-18 13:06:16 +00:00 committed by Gerrit Code Review
commit 4390ad247a
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
ansible/lvm.yml
View File

@ -4,7 +4,7 @@
tags: tags:
- lvm - lvm
- upgrade-check - upgrade-check
pre_tasks: tasks:
- name: Fail if the LVM physical disks have not been configured - name: Fail if the LVM physical disks have not been configured
fail: fail:
msg: > msg: >
@ -13,6 +13,7 @@
has a valid 'disks' list. has a valid 'disks' list.
with_items: "{{ lvm_groups | default([]) }}" with_items: "{{ lvm_groups | default([]) }}"
when: not item.disks | default([]) or 'changeme' in item.disks | default([]) when: not item.disks | default([]) or 'changeme' in item.disks | default([])
- name: Fail if the LVM physical disks are configured as a comma-separated string - name: Fail if the LVM physical disks are configured as a comma-separated string
fail: fail:
msg: > msg: >
@ -21,10 +22,14 @@
each volume group in 'lvm_groups' has a valid 'disks' list. each volume group in 'lvm_groups' has a valid 'disks' list.
with_items: "{{ lvm_groups | default([]) }}" with_items: "{{ lvm_groups | default([]) }}"
when: item.disks | string() == item.disks when: item.disks | string() == item.disks
roles:
- role: mrlesmithjr.manage-lvm - name: Ensure LVM configuration is applied
manage_lvm: True vars:
become: True manage_lvm: True
include_role:
name: mrlesmithjr.manage-lvm
apply:
become: True
when: when:
- lvm_groups is defined - lvm_groups is defined
- lvm_groups | length > 0 - lvm_groups | length > 0