From c7743aa615f0b8a404c59e924a487a352be6badf Mon Sep 17 00:00:00 2001
From: Pierre Riteau <pierre@stackhpc.com>
Date: Thu, 13 Dec 2018 15:40:43 +0000
Subject: [PATCH] Fix physical network configuration on Dell switches

The dellos Ansible modules do not accept a `transport` key in the
provider parameter anymore, even in Ansible 2.4.0.

Change-Id: I4bdaa337cb9c6cb93f36338a191a9aa78e2c13f0
Story: 2004588
Task: 28464
---
 ansible/group_vars/all/switches/dell                       | 1 -
 ansible/roles/dell-switch/README.md                        | 1 -
 .../fix-dell-physical-network-config-b4eaf752e62eeadb.yaml | 7 +++++++
 3 files changed, 7 insertions(+), 2 deletions(-)
 create mode 100644 releasenotes/notes/fix-dell-physical-network-config-b4eaf752e62eeadb.yaml

diff --git a/ansible/group_vars/all/switches/dell b/ansible/group_vars/all/switches/dell
index 4e3004e4c..4545d75bd 100644
--- a/ansible/group_vars/all/switches/dell
+++ b/ansible/group_vars/all/switches/dell
@@ -10,6 +10,5 @@ switch_dellos_provider:
   host: "{{ ansible_host|default(inventory_hostname) }}"
   username: "{{ ansible_user }}"
   password: "{{ ansible_ssh_pass }}"
-  transport: cli
   authorize: yes
   auth_pass: "{{ switch_auth_pass }}"
diff --git a/ansible/roles/dell-switch/README.md b/ansible/roles/dell-switch/README.md
index b158c6cc1..ad2ecfd41 100644
--- a/ansible/roles/dell-switch/README.md
+++ b/ansible/roles/dell-switch/README.md
@@ -57,7 +57,6 @@ passwords.  It applies global configuration for LLDP, and enables two
             host: "{{ switch_host }}"
             username: "{{ switch_user }}"
             password: "{{ switch_password }}"
-            transport: cli
             authorize: yes
             auth_pass: "{{ switch_auth_pass }}"
           dell_switch_config:
diff --git a/releasenotes/notes/fix-dell-physical-network-config-b4eaf752e62eeadb.yaml b/releasenotes/notes/fix-dell-physical-network-config-b4eaf752e62eeadb.yaml
new file mode 100644
index 000000000..b7ebe6677
--- /dev/null
+++ b/releasenotes/notes/fix-dell-physical-network-config-b4eaf752e62eeadb.yaml
@@ -0,0 +1,7 @@
+---
+fixes:
+  - |
+    Fixes a compatibility issue with Ansible modules for Dell switches which
+    was preventing physical network configuration for this type of hardware.
+    See `Story 2004588 <https://storyboard.openstack.org/#!/story/2004588>`__
+    for details.