Revert to yatesr.timezone role

In the 1.2.0 release the offending symlinks were removed from the role.

Also skip molecule tests from galaxy roles.

TrivialFix

Change-Id: I233e5468054e950a80355bdc2205bd6070a12297

ansible/ntp.yml

@@ -4,7 +4,7 @@
   tags:
     - ntp
   roles:
-    - role: stackhpc.timezone
+    - role: yatesr.timezone
       become: True
     - role: resmo.ntp
       become: True

kayobe/ansible.py

@@ -273,7 +273,7 @@ def prune_galaxy_roles(parsed_args):
         'stackhpc.os-flavors',
         'stackhpc.os-projects',
         'stackhpc.parted-1-1',
-        'yatesr.timezone',
+        'stackhpc.timezone',
     ]
     LOG.debug("Removing roles: %s", ",".join(roles_to_remove))
     utils.galaxy_remove(roles_to_remove, "ansible/roles")

kayobe/tests/unit/test_ansible.py

@@ -441,7 +441,7 @@ class TestCase(unittest.TestCase):
             'stackhpc.os-flavors',
             'stackhpc.os-projects',
             'stackhpc.parted-1-1',
-            'yatesr.timezone',
+            'stackhpc.timezone',
         ]
         mock_remove.assert_called_once_with(expected_roles,
                                             "ansible/roles")

requirements.yml

@@ -39,9 +39,5 @@
   version: v1.3.0
 - src: stackhpc.os-shade
   version: v1.3.0
-# We are currently using a fork of this role since the upstream yatesr.timezone
-# role includes symlinks which do not play nicely with PBR. Once that issue has
-# been resolved in PBR, we can revert to using the upstream yatesr.timezone
-# role.
-- src: stackhpc.timezone
+- src: yatesr.timezone
   version: 1.2.0

tools/test-molecule.sh

@@ -11,6 +11,12 @@ failed=0
 ran=0
 for molecule in $molecules; do
     pushd $(dirname $molecule)
+    # Don't run molecule tests from Galaxy roles.
+    if [[ -f meta/.galaxy_install_info ]]; then
+        echo "Skipping $(basename $(pwd)) as it is a Galaxy role"
+        popd
+        continue
+    fi
     if ! molecule test --all $*; then
         failed=$((failed + 1))
     fi