f639ad0b35
By default, Ansible injects a variable for every fact, prefixed with ansible_. This can result in a large number of variables for each host, which at scale can incur a performance penalty. Ansible provides a configuration option [0] that can be set to False to prevent this injection of facts. In this case, facts should be referenced via ansible_facts.<fact>. This change updates all references to Ansible facts within Kayobe from using individual fact variables to using the items in the ansible_facts dictionary. This allows users to disable fact variable injection in their Ansible configuration, which may provide some performance improvement. This change disables fact variable injection in the ansible configuration used in CI, to catch any attempts to use the injected variables. [0] https://docs.ansible.com/ansible/latest/reference_appendices/config.html#inject-facts-as-vars Story: 2007993 Task: 42464 Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/791276 Change-Id: I14db53ed6e57d37bbd28dd5819e432e3fe6628b2
64 lines
2.0 KiB
YAML
64 lines
2.0 KiB
YAML
---
|
|
- hosts: primary
|
|
vars:
|
|
ansible_cfg: |
|
|
[defaults]
|
|
# Ensure that facts are referenced via ansible_facts.<fact>.
|
|
inject_facts_as_vars = False
|
|
|
|
[ssh_connection]
|
|
pipelining = True
|
|
retries = 3
|
|
roles:
|
|
- role: kayobe-diagnostics
|
|
kayobe_diagnostics_phase: "pre"
|
|
kayobe_diagnostics_log_dir: "{{ logs_dir }}"
|
|
|
|
- role: kayobe-ci-prep
|
|
tasks:
|
|
# NOTE(mgoddard): Copying upper constraints to somewhere accessible by both
|
|
# the zuul and stack users.
|
|
- name: Ensure upper-constraints.txt exists
|
|
copy:
|
|
src: "{{ requirements_src_dir }}/upper-constraints.txt"
|
|
dest: "/tmp"
|
|
mode: 0644
|
|
remote_src: true
|
|
|
|
- name: Ensure kayobe is executed in verbose mode
|
|
lineinfile:
|
|
path: "{{ kayobe_src_dir }}/dev/config.sh"
|
|
line: "export KAYOBE_EXTRA_ARGS=-vvv"
|
|
regexp: "^#export KAYOBE_EXTRA_ARGS=$"
|
|
|
|
- name: Ensure ansible.cfg exists
|
|
copy:
|
|
content: "{{ ansible_cfg }}"
|
|
dest: "{{ kayobe_config_src_dir }}/etc/kayobe/ansible.cfg"
|
|
|
|
- block:
|
|
- name: Ensure previous kayobe directory exists
|
|
file:
|
|
path: "{{ previous_kayobe_src_dir }}"
|
|
state: directory
|
|
|
|
- name: Ensure previous kayobe repository is cloned
|
|
command: >-
|
|
git clone {{ kayobe_src_dir }} {{ previous_kayobe_src_dir }} -b stable/{{ previous_release | lower }}
|
|
|
|
- name: Ensure previous kayobe-config directory exists
|
|
file:
|
|
path: "{{ previous_kayobe_config_src_dir }}"
|
|
state: directory
|
|
|
|
- name: Ensure kayobe-config repository is cloned
|
|
command: >-
|
|
git clone {{ kayobe_config_src_dir }} {{ previous_kayobe_config_src_dir }} -b stable/{{ previous_release | lower }}
|
|
|
|
- name: Ensure previous kayobe is executed in verbose mode
|
|
lineinfile:
|
|
path: "{{ previous_kayobe_src_dir }}/dev/config.sh"
|
|
line: "export KAYOBE_EXTRA_ARGS=-vvv"
|
|
regexp: "^#export KAYOBE_EXTRA_ARGS=$"
|
|
when: is_upgrade
|