Mark Goddard 50e04bb06f Drop become in stackhpc.libvirt-vm for seed vm provision
Prior to this change, the seed VM was provisioned using the
stackhpc.livirt-vm role with become=true. This resulted in the cached
image being owned by root. The infra VM provisioning uses
stackhpc.libvirt-vm without become=true. If an infra VM uses the same
image as the seed, this can lead to permission denied errors when
downloading a new image of the same name.

This change adds a workaround to fix up the ownership of the cached
image during infra VM provisioning to avoid this issue.

This change also drops become=true from stackhpc.libvirt-vm during seed
VM provisioning, and adds the same workaround there.

Story: 2009277
Task: 43534

Change-Id: Iade0d74cdb398365a567dbdc4b23de2416f3726d
2021-10-27 10:00:03 +01:00

94 lines
3.6 KiB
YAML

---
- name: "[{{ vm_name }}] Ensure that the VM configdrive exists"
include_role:
name: jriguera.configdrive
vars:
configdrive_os_family: "{{ vm_hostvars.infra_vm_os_family }}"
configdrive_uuid: "{{ vm_name | to_uuid }}"
# Must set configdrive_instance_dir when using a loop
# https://github.com/jriguera/ansible-role-configdrive/blob/8438592c84585c86e62ae07e526d3da53629b377/tasks/main.yml#L17
configdrive_instance_dir: "{{ configdrive_uuid }}"
configdrive_fqdn: "{{ vm_name }}"
configdrive_name: "{{ vm_name }}"
configdrive_ssh_public_key: "{{ lookup('file', ssh_public_key_path) }}"
configdrive_config_dir: "{{ image_cache_path }}"
configdrive_volume_path: "{{ image_cache_path }}"
configdrive_config_dir_delete: False
configdrive_resolv:
domain: "{{ vm_hostvars.resolv_domain | default }}"
search: "{{ vm_hostvars.resolv_search | default }}"
dns: "{{ vm_hostvars.resolv_nameservers | default([]) }}"
configdrive_network_device_list: >
{{ vm_hostvars.network_interfaces |
map('net_configdrive_network_device', vm_hostvars.inventory_hostname) |
list }}
- name: "[{{ vm_name }}] Set a fact containing the configdrive image path"
set_fact:
vm_configdrive_path: "{{ image_cache_path }}/{{ vm_name }}.iso"
- name: "[{{ vm_name }}] Ensure configdrive is decoded and decompressed"
shell: >
base64 -d {{ image_cache_path }}/{{ vm_name | to_uuid }}.gz
| gunzip
> {{ vm_configdrive_path }}
- name: "[{{ vm_name }}] Ensure unnecessary files are removed"
file:
path: "{{ item }}"
state: absent
with_items:
- "{{ image_cache_path }}/{{ vm_name | to_uuid }}.gz"
- name: "[{{ vm_name }}] Check the size of the configdrive image"
stat:
path: "{{ vm_configdrive_path }}"
get_checksum: False
get_md5: False
mime: False
register: stat_result
# NOTE(mgoddard): Prior to the Xena release, the seed VM was provisioned using
# the stackhpc.livirt-vm role with become=true. This resulted in the cached
# image being owned by root. Since Xena, we execute the role without
# become=true. Correct the image ownership to avoid a permission denied error
# when downloading a new image of the same name.
- name: "[{{ vm_name }}] Stat image files"
stat:
path: "{{ image_cache_path }}/{{ item.image | basename }}"
with_items: "{{ vm_hostvars.infra_vm_volumes | selectattr('image', 'defined') }}"
register: image_stat_result
- name: "[{{ vm_name }}] Fix image ownership"
file:
path: "{{ image_cache_path }}/{{ item.item.image | basename }}"
owner: "{{ ansible_facts.user_uid }}"
group: "{{ ansible_facts.user_gid }}"
with_items: "{{ image_stat_result.results }}"
when: item.stat.exists
become: true
- name: "[{{ vm_name }}] Ensure that the VM is provisioned"
include_role:
name: stackhpc.libvirt-vm
vars:
vm_configdrive_device: cdrom
vm_configdrive_volume:
name: "{{ vm_name }}-configdrive"
pool: "{{ vm_hostvars.infra_vm_pool }}"
# Round size up to next multiple of 4096.
capacity: "{{ (stat_result.stat.size + 4095) // 4096 * 4096 }}"
device: "{{ vm_configdrive_device }}"
format: "raw"
image: "{{ vm_configdrive_path }}"
remote_src: true
libvirt_vm_image_cache_path: "{{ image_cache_path }}"
libvirt_vms:
- name: "{{ vm_name }}"
memory_mb: "{{ vm_hostvars.infra_vm_memory_mb }}"
vcpus: "{{ vm_hostvars.infra_vm_vcpus }}"
volumes: "{{ vm_hostvars.infra_vm_volumes + [vm_configdrive_volume] }}"
interfaces: "{{ vm_hostvars.infra_vm_interfaces }}"
console_log_enabled: true