openstack/keystonemiddleware
Code Issues Proposed changes

Replace deprecated library function os.popen() with subprocess

Browse Source 
os.popen() is deprecated since version 2.6. Resolved with use of
subprocess module.
Closes-bug: #1529836

Change-Id: I3f78fff64f100aa7d435c830a2a913a521af698e
This commit is contained in:
LiuNanke 2016-01-13 22:47:14 +08:00
parent 650531310c
commit 5dba16bc13
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
doc/source/conf.py
View File

@ -15,6 +15,7 @@
from __future__ import unicode_literals
import os
import subprocess
import sys
import pbr.version
@ -158,8 +159,10 @@ man_pages = []
# If not '', a 'Last updated on:' timestamp is inserted at every page bottom,
# using the given strftime format.
git_cmd = "git log --pretty=format:'%ad, commit %h' --date=local -n1"
html_last_updated_fmt = os.popen(git_cmd).read()
git_cmd = ["git", "log", "--pretty=format:'%ad, commit %h'", "--date=local",
"-n1"]
html_last_updated_fmt = subprocess.Popen(
git_cmd, stdout=subprocess.PIPE).communicate()[0]
# If true, SmartyPants will be used to convert quotes and dashes to
# typographically correct entities.