openstack/keystonemiddleware
Code Issues Proposed changes

Merge "Use new ksc features in User Token Plugin"

Browse Source
This commit is contained in:
Jenkins 2014-12-12 02:11:11 +00:00 committed by Gerrit Code Review
commit 791948cf07
1 changed files with 8 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
keystonemiddleware/auth_token.py
View File

@ -687,24 +687,14 @@ class _UserAuthPlugin(base_identity.BaseIdentityPlugin):
authentication plugin when communicating via a session. authentication plugin when communicating via a session.
""" """
def __init__(self, user_token, auth_ref): def __init__(self, auth_ref):
# FIXME(jamielennox): set reauthenticate=False here when keystoneclient super(_UserAuthPlugin, self).__init__(reauthenticate=False)
# 0.11 is released to prevent trying to refetch authentication.
super(_UserAuthPlugin, self).__init__()
self._user_token = user_token
self._stored_auth_ref = auth_ref self._stored_auth_ref = auth_ref
def get_token(self, session, **kwargs):
# NOTE(jamielennox): This is needed partially because the AccessInfo
# factory is so bad that we don't always get the correct token data.
# Override and always return the token that was provided in the req.
return self._user_token
def get_auth_ref(self, session, **kwargs): def get_auth_ref(self, session, **kwargs):
# NOTE(jamielennox): We can't go out and fetch this auth_ref, we've # NOTE(jamielennox): We will always use the auth_ref that was
# got it already so always return it. In the event it tries to # calculated by the middleware. reauthenticate=False in __init__ should
# re-authenticate it will get the same old auth_ref which is not # ensure that this function is only called on the first access.
# perfect, but the best we can do for now.
return self._stored_auth_ref return self._stored_auth_ref
@ -802,10 +792,10 @@ class AuthProtocol(object):
self._LOG.debug('Authenticating user token') self._LOG.debug('Authenticating user token')
user_token = self._get_user_token_from_header(env) user_token = self._get_user_token_from_header(env)
token_info = self._validate_token(user_token, env) token_info = self._validate_token(user_token, env)
auth_ref = access.AccessInfo.factory(body=token_info) auth_ref = access.AccessInfo.factory(body=token_info,
auth_token=user_token)
env['keystone.token_info'] = token_info env['keystone.token_info'] = token_info
env['keystone.token_auth'] = _UserAuthPlugin( env['keystone.token_auth'] = _UserAuthPlugin(auth_ref)
user_token, auth_ref)
user_headers = self._build_user_headers(auth_ref, token_info) user_headers = self._build_user_headers(auth_ref, token_info)
self._add_headers(env, user_headers) self._add_headers(env, user_headers)
except InvalidToken: except InvalidToken: