Fix haproxy restarting twice per Ansible run

Since haproxy is orchestrated via site.yml in a single play,
it does not need flushing handlers as handlers run will
happen at the end of this play.

Change-Id: Ia3743575da707325be93c39b4a2bcae9211cacb2
Related-Bug: #1864810
Closes-Bug: #1875228

ansible/roles/haproxy/tasks/deploy.yml

@@ -3,5 +3,7 @@
 
 - include_tasks: config.yml
 
-- name: Flush handlers
-  meta: flush_handlers
+# NOTE(yoctozepto): haproxy role handlers should not be flushed early.
+# site.yml handles all haproxy things in a dedicated play.
+# This is to avoid extra haproxy service restart.
+# See: https://bugs.launchpad.net/kolla-ansible/+bug/1875228

ansible/roles/haproxy/tasks/upgrade.yml

@@ -16,5 +16,7 @@
   notify:
     - Restart keepalived container
 
-- name: Flush handlers
-  meta: flush_handlers
+# NOTE(yoctozepto): haproxy role handlers should not be flushed early.
+# site.yml handles all haproxy things in a dedicated play.
+# This is to avoid extra haproxy service restart.
+# See: https://bugs.launchpad.net/kolla-ansible/+bug/1875228

releasenotes/notes/bug-1864810-5a5d0f91c0171b19.yaml

@@ -0,0 +1,7 @@
+---
+fixes:
+  - |
+    Fixes haproxy role to avoid restarting haproxy service multiple times
+    in a single Ansible run.
+    `LP#1864810 <https://launchpad.net/bugs/1864810>`__
+    `LP#1875228 <https://launchpad.net/bugs/1875228>`__