openstack/kolla-ansible
Code Issues Proposed changes

ansible: Use assert on checks for readability

Browse Source 
assert will also fail when we're not meeting the conditions, makes
clear what we're actually testing, and isn't listed as a skipped task
when the condition is ok.

Change-Id: I20a48bb2eaa3715c6351f5ede04c191ea0a10d3d
This commit is contained in:
Erik Berg 2023-01-09 18:33:50 +01:00
parent 2b88144c05
commit 0573356d16
No known key found for this signature in database
GPG Key ID: 1182D19B0E5ED030
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ansible/roles/prechecks/tasks/package_checks.yml
View File

@ -12,11 +12,13 @@
# to check. as ansible_version does not provide major.minor in dict, we need to # to check. as ansible_version does not provide major.minor in dict, we need to
# set it as variable. # set it as variable.
- name: Checking Ansible version - name: Checking Ansible version
vars: assert:
ansible_version_host: "{{ ansible_version.major }}.{{ ansible_version.minor }}" that:
fail: - ansible_version_host is version(ansible_version_min, '>=')
msg: >- - ansible_version_host is version(ansible_version_max, '<=')
fail_msg: >-
Ansible version should be between {{ ansible_version_min }} and {{ ansible_version_max }}. Ansible version should be between {{ ansible_version_min }} and {{ ansible_version_max }}.
Current version is {{ ansible_version.full }} which is not supported. Current version is {{ ansible_version.full }} which is not supported.
vars:
ansible_version_host: "{{ ansible_version.major }}.{{ ansible_version.minor }}"
run_once: true run_once: true
when: ansible_version_host is version(ansible_version_min, '<') or ansible_version_host is version(ansible_version_max, '>')