openstack/kolla-ansible
Code Issues Proposed changes

Have test retry building failed images

Browse Source 
The image build test now retries 3 times before declaring an image as
failing. This should help the gate in case of unreliable network
connectivity to the mirrors.

We expect the penalty of retrying to build failed images to be low
thanks to docker cache. Only the failing layer should be retried.

Change-Id: I15fd4926019590a150eb22dc885d0ef8cd31e7cc
Closes-Bug: #1466677
This commit is contained in:
Martin André 2015-06-25 22:21:04 +09:00
parent f370edfb70
commit 091ef5a5cb
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/test_images.py
View File

@ -26,7 +26,8 @@ class ImagesTest(base.BaseTestCase):
def test_builds(self): def test_builds(self):
proc = Popen(['tools/build-all-docker-images', proc = Popen(['tools/build-all-docker-images',
'--testmode'], '--testmode',
'--retry 3'],
stdout=PIPE, stderr=STDOUT, bufsize=1) stdout=PIPE, stderr=STDOUT, bufsize=1)
with proc.stdout: with proc.stdout:
for line in iter(proc.stdout.readline, b''): for line in iter(proc.stdout.readline, b''):