From 10b72b98e038ca47440d4b1b1731026d068508db Mon Sep 17 00:00:00 2001 From: Stig Telfer Date: Fri, 14 Jan 2022 13:08:29 +0000 Subject: [PATCH] Fix post-config of OVS for manila-share servers A host that is in the manila-share group, but not in controllers network, etc., will fail service deployment if it is not using the generic manila driver (eg, if it is using the CephFS native driver). This is because deployment of openvswitch-vswitchd is predicated on the drivers enabled for manila-share. However, this predicate is not universally applied. Where inventory group membership is used the dependency on openvswitch-vswitchd presence will fail. Closes-Bug: #1993285 Change-Id: I821e513d24f2a1c59240d65ad68c3b5f2080e439 --- ansible/roles/openvswitch/tasks/post-config.yml | 2 ++ releasenotes/notes/bug-1993285-127fe764e461465a.yaml | 5 +++++ 2 files changed, 7 insertions(+) create mode 100644 releasenotes/notes/bug-1993285-127fe764e461465a.yaml diff --git a/ansible/roles/openvswitch/tasks/post-config.yml b/ansible/roles/openvswitch/tasks/post-config.yml index 1714ad4e77..e2d92a545c 100644 --- a/ansible/roles/openvswitch/tasks/post-config.yml +++ b/ansible/roles/openvswitch/tasks/post-config.yml @@ -17,6 +17,8 @@ - { col: "external_ids", name: "system-id", value: "{{ openvswitch_system_id }}" } - { col: "external_ids", name: "hostname", value: "{{ openvswitch_hostname }}" } - { col: "other_config", name: "hw-offload", value: true, state: "{{ 'present' if openvswitch_hw_offload | bool else 'absent' }}" } + when: + - openvswitch_services['openvswitch-vswitchd'].host_in_groups | bool - name: Ensuring OVS bridge is properly setup become: true diff --git a/releasenotes/notes/bug-1993285-127fe764e461465a.yaml b/releasenotes/notes/bug-1993285-127fe764e461465a.yaml new file mode 100644 index 0000000000..068c6e73f1 --- /dev/null +++ b/releasenotes/notes/bug-1993285-127fe764e461465a.yaml @@ -0,0 +1,5 @@ +--- +fixes: + - | + Fixes handling of openvswitch on ``manila-share`` nodes. + `LP#1993285 `__