From 22cea7f08cd853572476780e80cd7ee22fbca56f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rados=C5=82aw=20Piliszek?= <radoslaw.piliszek@gmail.com>
Date: Wed, 16 Oct 2019 09:51:51 +0200
Subject: [PATCH] CI: run check-logs in post too

Also makes check-logs clear the aggregate files
to prevent duplicates due to upgrade and post.

Change-Id: I72377b6ac48e29dc5e24d1e3bd343e87b74a7a71
---
 tests/check-logs.sh | 2 ++
 tests/post.yml      | 8 ++++++++
 2 files changed, 10 insertions(+)

diff --git a/tests/check-logs.sh b/tests/check-logs.sh
index 179a7f6f3a..c298dd3865 100755
--- a/tests/check-logs.sh
+++ b/tests/check-logs.sh
@@ -19,6 +19,8 @@ function check_file_for_level {
 any_critical=0
 for level in CRITICAL ERROR WARNING; do
     all_file=/tmp/logs/kolla/all-${level}.log
+    # remove the file to avoid collecting duplicates (upgrade, post)
+    rm -f $all_file
     any_matched=0
     echo "Checking for $level log messages"
     for f in $(sudo find /var/log/kolla/ -type f); do
diff --git a/tests/post.yml b/tests/post.yml
index 48ad13f587..b742c06b30 100644
--- a/tests/post.yml
+++ b/tests/post.yml
@@ -8,6 +8,14 @@
         content: "{{ hostvars[inventory_hostname] | to_nice_json }}"
         dest: "{{ logs_dir }}/facts.json"
 
+    # NOTE(yoctozepto): this might not have been run during the
+    # regular run due to some earlier failure, yet logs content may
+    # still provide insight into that other, breaking issue
+    - name: Run check-logs.sh script
+      script: check-logs.sh
+      failed_when: false
+      when: not zuul_success | bool
+
     - name: Run diagnostics script
       environment:
         KOLLA_INTERNAL_VIP_ADDRESS: "{{ kolla_internal_vip_address }}"