openstack/kolla-ansible
Code Issues Proposed changes

Merge "Fix deploy/genconfig in check mode"

Browse Source
This commit is contained in:
Zuul 2023-03-23 10:55:24 +00:00 committed by Gerrit Code Review
commit 2845861ef9
5 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ansible/roles/keystone/tasks/config.yml
View File

@ -199,6 +199,7 @@
-i {{ groups['keystone'].index(inventory_hostname) }} -i {{ groups['keystone'].index(inventory_hostname) }}
-n {{ (groups['keystone'] | length) }} -n {{ (groups['keystone'] | length) }}
changed_when: false changed_when: false
check_mode: false
register: cron_jobs_json register: cron_jobs_json
connection: local connection: local
delegate_to: localhost delegate_to: localhost

1
ansible/roles/mariadb/tasks/lookup_cluster.yml
View File

@ -50,6 +50,7 @@
--silent --skip-column-names --silent --skip-column-names
-e 'SHOW STATUS LIKE "wsrep_local_state_comment"' -e 'SHOW STATUS LIKE "wsrep_local_state_comment"'
changed_when: false changed_when: false
check_mode: false
register: check_mariadb_sync_status register: check_mariadb_sync_status
no_log: true no_log: true

1
ansible/roles/nova-cell/tasks/get_cell_settings.yml
View File

@ -18,6 +18,7 @@
changed_when: false changed_when: false
failed_when: failed_when:
- existing_cells_list.rc != 0 - existing_cells_list.rc != 0
check_mode: false
- name: Extract current cell settings from list - name: Extract current cell settings from list
vars: vars:

1
ansible/roles/nova-cell/tasks/wait_discover_computes.yml
View File

@ -23,6 +23,7 @@
register: nova_compute_services register: nova_compute_services
changed_when: false changed_when: false
failed_when: false failed_when: false
check_mode: false
retries: 20 retries: 20
delay: 10 delay: 10
until: until:

5
releasenotes/notes/fix-check-mode-1f37ab5507c98954.yaml Normal file
View File

@ -0,0 +1,5 @@
---
fixes:
- |
Fixes deployment when using Ansible check mode. `LP#2002661
<https://bugs.launchpad.net/kolla-ansible/+bug/2002661>`__