From 1537f6ed6616a52e73520972370b0a47032a0836 Mon Sep 17 00:00:00 2001
From: Jeffrey Zhang <zhang.lei.fly@gmail.com>
Date: Mon, 1 Jul 2019 17:48:22 +0800
Subject: [PATCH] Remove FWaaS v1 related options

Neutron FWaaS v1 is deprecated and removed since stein cycle by [0]. So
remove related options in kolla.

[0] https://review.opendev.org/616410

Change-Id: Ia03e7979dd48bafb34c11edd08c2a2a87b949e0e
---
 ansible/roles/neutron/defaults/main.yml               | 11 ++---------
 ansible/roles/neutron/templates/fwaas_driver.ini.j2   |  5 -----
 .../notes/remove-fwaas-v1-6d75b742ebbf0c56.yaml       |  7 +++++++
 3 files changed, 9 insertions(+), 14 deletions(-)
 create mode 100644 releasenotes/notes/remove-fwaas-v1-6d75b742ebbf0c56.yaml

diff --git a/ansible/roles/neutron/defaults/main.yml b/ansible/roles/neutron/defaults/main.yml
index d308869b85..5ffa0d2b52 100644
--- a/ansible/roles/neutron/defaults/main.yml
+++ b/ansible/roles/neutron/defaults/main.yml
@@ -342,9 +342,6 @@ ironic_neutron_agent_extra_volumes: "{{ neutron_extra_volumes }}"
 dhcp_agents_per_network: 2
 max_l3_agents_per_router: 3
 
-# valid value is: ["v1", "v2"]
-neutron_fwaas_version: "v1"
-
 neutron_admin_endpoint: "{{ admin_protocol }}://{{ neutron_internal_fqdn }}:{{ neutron_server_port }}"
 neutron_internal_endpoint: "{{ internal_protocol }}://{{ neutron_internal_fqdn }}:{{ neutron_server_port }}"
 neutron_public_endpoint: "{{ public_protocol }}://{{ neutron_external_fqdn }}:{{ neutron_server_port }}"
@@ -380,10 +377,8 @@ neutron_rolling_upgrade_services: ["neutron", "neutron-fwaas", "neutron-vpnaas"]
 # Service Plugins
 ####################
 service_plugins:
-  - name: "firewall"
-    enabled: "{{ enable_neutron_fwaas | bool and neutron_fwaas_version == 'v1' }}"
   - name: "firewall_v2"
-    enabled: "{{ enable_neutron_fwaas | bool and neutron_fwaas_version == 'v2' }}"
+    enabled: "{{ enable_neutron_fwaas }}"
   - name: "flow_classifier"
     enabled: "{{ enable_neutron_sfc | bool }}"
   - name: "lbaasv2"
@@ -434,10 +429,8 @@ agent_extensions:
 neutron_agent_extensions: "{{ agent_extensions | selectattr('enabled', 'equalto', true) | list }}"
 
 l3_agent_extensions:
-  - name: "fwaas"
-    enabled: "{{ enable_neutron_fwaas | bool and neutron_fwaas_version == 'v1' }}"
   - name: "fwaas_v2"
-    enabled: "{{ enable_neutron_fwaas | bool and neutron_fwaas_version == 'v2' }}"
+    enabled: "{{ enable_neutron_fwaas | bool }}"
   - name: "vpnaas"
     enabled: "{{ enable_neutron_vpnaas | bool }}"
 
diff --git a/ansible/roles/neutron/templates/fwaas_driver.ini.j2 b/ansible/roles/neutron/templates/fwaas_driver.ini.j2
index 01b4391ead..159b1e1117 100644
--- a/ansible/roles/neutron/templates/fwaas_driver.ini.j2
+++ b/ansible/roles/neutron/templates/fwaas_driver.ini.j2
@@ -4,13 +4,8 @@ enabled = True
 {% if neutron_plugin_agent == 'vmware_nsxv' %}
 driver = vmware_nsxv_edge
 {% else %}
-{% if neutron_fwaas_version == 'v1' %}
-agent_version = v1
-driver = iptables
-{% elif neutron_fwaas_version == 'v2' %}
 agent_version = v2
 driver = iptables_v2
-{% endif %}
 
 [service_providers]
 service_provider = FIREWALL:Iptables:neutron.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver:default
diff --git a/releasenotes/notes/remove-fwaas-v1-6d75b742ebbf0c56.yaml b/releasenotes/notes/remove-fwaas-v1-6d75b742ebbf0c56.yaml
new file mode 100644
index 0000000000..16f0ba839d
--- /dev/null
+++ b/releasenotes/notes/remove-fwaas-v1-6d75b742ebbf0c56.yaml
@@ -0,0 +1,7 @@
+---
+deprecations:
+  - |
+    Neutron FWaaS v1 is deprecated and removed since stein cycle by [0]. So
+    remove related options in kolla.
+
+    [0] https://review.opendev.org/616410